Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1286

Remove netty dependency from tajo-jdbc

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: JDBC Driver
    • Labels:
      None

      Description

      tajo-jdbc module depends on the netty class, QueryStringDecoder. It has no problem since we use the netty 3.x library, but when we use the netty 4.x or above, netty http codec library includes bunches of netty modules for itself. It needs to clean up dependencies from tajo jdbc driver.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user ykrips opened a pull request:

        https://github.com/apache/tajo/pull/341

        TAJO-1286: Remove netty dependency from tajo-jdbc

        Though JdbcConnection class does not use parameters on its class, this QueryStringDecoder class was implemented for future use.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/ykrips/tajo TAJO-1286

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/341.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #341


        commit b206bb7fb42d5da6eb69dbfee3d222ca93b1194c
        Author: Jihun Kang <jihun@apache.org>
        Date: 2015-01-08T06:56:27Z

        TAJO-1286: Remove netty dependency from tajo-jdbc

        commit 3807d3ce347f7e4fb7caab34ff93936830396307
        Author: Jihun Kang <jihun@apache.org>
        Date: 2015-01-09T04:09:11Z

        TAJO-1286: Remove netty dependency from tajo-jdbc

        commit 5f14f7e70522631a78d50e6aad2691097e71213f
        Author: Jihun Kang <jihun@apache.org>
        Date: 2015-01-09T04:14:02Z

        Merge remote-tracking branch 'upstream/master' into TAJO-1286


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user ykrips opened a pull request: https://github.com/apache/tajo/pull/341 TAJO-1286 : Remove netty dependency from tajo-jdbc Though JdbcConnection class does not use parameters on its class, this QueryStringDecoder class was implemented for future use. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ykrips/tajo TAJO-1286 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #341 commit b206bb7fb42d5da6eb69dbfee3d222ca93b1194c Author: Jihun Kang <jihun@apache.org> Date: 2015-01-08T06:56:27Z TAJO-1286 : Remove netty dependency from tajo-jdbc commit 3807d3ce347f7e4fb7caab34ff93936830396307 Author: Jihun Kang <jihun@apache.org> Date: 2015-01-09T04:09:11Z TAJO-1286 : Remove netty dependency from tajo-jdbc commit 5f14f7e70522631a78d50e6aad2691097e71213f Author: Jihun Kang <jihun@apache.org> Date: 2015-01-09T04:14:02Z Merge remote-tracking branch 'upstream/master' into TAJO-1286
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/341#issuecomment-69296396

        +1 ship it. The patch looks good to me.

        Even though TestTajoClient.testKillQuery causes one test failures, it is not related to this issue. Actually, I'm digging this problem. I'll fix this problem in another jira. Your patch seems to work correctly.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/341#issuecomment-69296396 +1 ship it. The patch looks good to me. Even though TestTajoClient.testKillQuery causes one test failures, it is not related to this issue. Actually, I'm digging this problem. I'll fix this problem in another jira. Your patch seems to work correctly.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user ykrips commented on the pull request:

        https://github.com/apache/tajo/pull/341#issuecomment-69299480

        Hello @hyunsik,
        Thank you for reviewing this issue. This pull request will be merged into master branch.

        Show
        githubbot ASF GitHub Bot added a comment - Github user ykrips commented on the pull request: https://github.com/apache/tajo/pull/341#issuecomment-69299480 Hello @hyunsik, Thank you for reviewing this issue. This pull request will be merged into master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/341

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/341
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #545 (See https://builds.apache.org/job/Tajo-master-build/545/)
        TAJO-1286: Remove netty dependency from tajo-jdbc (jihun: rev 533601eac6a21251485576ba693635d1650b63a4)

        • tajo-jdbc/src/test/java/org/apache/tajo/jdbc/util/TestQueryStringDecoder.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java
        • tajo-jdbc/pom.xml
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/util/QueryStringDecoder.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #545 (See https://builds.apache.org/job/Tajo-master-build/545/ ) TAJO-1286 : Remove netty dependency from tajo-jdbc (jihun: rev 533601eac6a21251485576ba693635d1650b63a4) tajo-jdbc/src/test/java/org/apache/tajo/jdbc/util/TestQueryStringDecoder.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java tajo-jdbc/pom.xml tajo-jdbc/src/main/java/org/apache/tajo/jdbc/util/QueryStringDecoder.java CHANGES
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #184 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/184/)
        TAJO-1286: Remove netty dependency from tajo-jdbc (jihun: rev 533601eac6a21251485576ba693635d1650b63a4)

        • tajo-jdbc/pom.xml
        • tajo-jdbc/src/test/java/org/apache/tajo/jdbc/util/TestQueryStringDecoder.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/util/QueryStringDecoder.java
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #184 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/184/ ) TAJO-1286 : Remove netty dependency from tajo-jdbc (jihun: rev 533601eac6a21251485576ba693635d1650b63a4) tajo-jdbc/pom.xml tajo-jdbc/src/test/java/org/apache/tajo/jdbc/util/TestQueryStringDecoder.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/util/QueryStringDecoder.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java CHANGES

          People

          • Assignee:
            ykrips Jihun Kang
            Reporter:
            ykrips Jihun Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development