Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1281

Remove hadoop-common dependency from tajo-rpc

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: RPC
    • Labels:
      None

      Description

      tajo-rpc depends on hadoop-common due to only one integer configurable parameter. As a result, it naturally depends on lots of third-party libraries.

      The main objective of this issue removes a hadoop-common dependency from tajo-rpc. It will maker TAJO-1160 easier.

      1. TAJO-1281.patch
        31 kB
        Hyunsik Choi

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/343

          TAJO-1281: Remove hadoop-common dependency from tajo-rpc.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-1281

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/343.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #343


          commit ee5f27951d0024f80dbb37d56b7b7090221b36b0
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-01-09T14:51:24Z

          TAJO-1281: Remove hadoop-common dependency from tajo-rpc.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/343 TAJO-1281 : Remove hadoop-common dependency from tajo-rpc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1281 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/343.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #343 commit ee5f27951d0024f80dbb37d56b7b7090221b36b0 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-01-09T14:51:24Z TAJO-1281 : Remove hadoop-common dependency from tajo-rpc.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12691149/TAJO-1281.patch
          against master revision release-0.9.0-rc0-135-g807868b.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 165 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 297 release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/571//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/571//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/571//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/571//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/571//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691149/TAJO-1281.patch against master revision release-0.9.0-rc0-135-g807868b. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 165 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 297 release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/571//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/571//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/571//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/571//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/571//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/343#issuecomment-69441899

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/343#issuecomment-69441899 +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/343

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/343
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed. thanks for the quick review.

          Show
          hyunsik Hyunsik Choi added a comment - committed. thanks for the quick review.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #548 (See https://builds.apache.org/job/Tajo-master-build/548/)
          TAJO-1281: Remove hadoop-common dependency from tajo-rpc. (hyunsik: rev 9eac34fe3121b8bc6bbe1b81ca76852ddedb2603)

          • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcUtils.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java
          • tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java
          • CHANGES
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java
          • tajo-rpc/pom.xml
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java
          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
          • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #548 (See https://builds.apache.org/job/Tajo-master-build/548/ ) TAJO-1281 : Remove hadoop-common dependency from tajo-rpc. (hyunsik: rev 9eac34fe3121b8bc6bbe1b81ca76852ddedb2603) tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcUtils.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java CHANGES tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java tajo-rpc/pom.xml tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Tajo-master-CODEGEN-build #187 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/187/)
          TAJO-1281: Remove hadoop-common dependency from tajo-rpc. (hyunsik: rev 9eac34fe3121b8bc6bbe1b81ca76852ddedb2603)

          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
          • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcUtils.java
          • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java
          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java
          • tajo-rpc/pom.xml
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #187 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/187/ ) TAJO-1281 : Remove hadoop-common dependency from tajo-rpc. (hyunsik: rev 9eac34fe3121b8bc6bbe1b81ca76852ddedb2603) tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcUtils.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java tajo-rpc/pom.xml

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development