Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1234

Rearrange timezone in date/time types

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Labels:
      None

      Description

      Currently, the master branch causes unit test failures. It's because that some inconsistent timezone usages. The main purpose of this issue is to cleanup and rearrange timezone usages.

      I discussed this issue with Jaewoong Jung at

      I'll fix some parts as I mentioned in above mailing list threads.

      In sum,

      • Tajo will have only four points which consider timezone:
        • query statement
        • Input table
        • text printout in TajoCli
        • Casting from text to either time or timestamp
      • All other parts have to deal with TIME and TIMESTAMP values as UTC value
      1. TAJO-1234_2.patch
        135 kB
        Hyunsik Choi
      2. TAJO-1234_3.patch
        142 kB
        Hyunsik Choi
      3. TAJO-1234_4.patch
        144 kB
        Hyunsik Choi
      4. TAJO-1234_5.patch
        144 kB
        Hyunsik Choi
      5. TAJO-1234_6.patch
        145 kB
        Hyunsik Choi
      6. TAJO-1234.patch
        85 kB
        Hyunsik Choi

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/290

          TAJO-1234: Rearrange timezone in date/time types.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-1234

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/290.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #290


          commit 9e24edbfbaa75bcb7aae1b83e097450048b788bd
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2014-12-06T14:30:28Z

          TAJO-1234: Rearrange timezone in date/time types.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/290 TAJO-1234 : Rearrange timezone in date/time types. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1234 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/290.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #290 commit 9e24edbfbaa75bcb7aae1b83e097450048b788bd Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-12-06T14:30:28Z TAJO-1234 : Rearrange timezone in date/time types.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-65926468

          I've updated the patch.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-65926468 I've updated the patch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-65926497

          This is an urgent issue. So, I would be happy if anyone review it as soon as possible.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-65926497 This is an urgent issue. So, I would be happy if anyone review it as soon as possible.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12685588/TAJO-1234_2.patch
          against master revision release-0.9.0-rc0-73-gab2efce.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 21 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 393 release audit warnings.

          -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage:
          org.apache.tajo.engine.query.TestSelectQuery
          org.apache.tajo.jdbc.TestResultSet

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/529//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/529//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685588/TAJO-1234_2.patch against master revision release-0.9.0-rc0-73-gab2efce. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 393 release audit warnings. -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage: org.apache.tajo.engine.query.TestSelectQuery org.apache.tajo.jdbc.TestResultSet Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/529//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/529//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/529//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-65927813

          I've updated the documentation.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-65927813 I've updated the documentation.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-65928449

          I found that some unit tests are sensitive to local time zone. I'll update the patch soon

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-65928449 I found that some unit tests are sensitive to local time zone. I'll update the patch soon
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12685591/TAJO-1234_3.patch
          against master revision release-0.9.0-rc0-73-gab2efce.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 21 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 394 release audit warnings.

          -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage:
          org.apache.tajo.engine.query.TestSelectQuery
          org.apache.tajo.jdbc.TestResultSet

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/530//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/530//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685591/TAJO-1234_3.patch against master revision release-0.9.0-rc0-73-gab2efce. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 394 release audit warnings. -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage: org.apache.tajo.engine.query.TestSelectQuery org.apache.tajo.jdbc.TestResultSet Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/530//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/530//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/530//console This message is automatically generated.
          Hide
          hyunsik Hyunsik Choi added a comment -

          I've updated the patch.

          Show
          hyunsik Hyunsik Choi added a comment - I've updated the patch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-65938801

          I've updated the patch.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-65938801 I've updated the patch.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12685609/TAJO-1234_4.patch
          against master revision release-0.9.0-rc0-74-g95cf4b9.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 22 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 179 release audit warnings.

          -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage:
          org.apache.tajo.engine.query.TestSelectQuery

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/531//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/531//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685609/TAJO-1234_4.patch against master revision release-0.9.0-rc0-74-g95cf4b9. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 22 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 179 release audit warnings. -1 core tests. The patch failed these unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage: org.apache.tajo.engine.query.TestSelectQuery Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/531//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/531//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/531//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-65965102

          Java 6 does not recognize 'UTC+9' or some location-based time zone like 'Asia/Seoul' because it has scarce time zone databases.

          I fixed the problematic unit tests to use the prefix 'GMT' instead of 'UTC'.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-65965102 Java 6 does not recognize 'UTC+9' or some location-based time zone like 'Asia/Seoul' because it has scarce time zone databases. I fixed the problematic unit tests to use the prefix 'GMT' instead of 'UTC'.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12685646/TAJO-1234_5.patch
          against master revision release-0.9.0-rc0-74-g95cf4b9.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 22 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 117 release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/532//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/532//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685646/TAJO-1234_5.patch against master revision release-0.9.0-rc0-74-g95cf4b9. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 22 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 117 release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/532//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/532//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/532//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-65966314

          In addition, I added the table property 'timezone'. You can use it in your ``CREATE TABLE`` statement as follows:

          ```sql
          CREATE EXTERNAL TABLE table1 (
          t_timestamp TIMESTAMP,
          t_time TIME,
          t_date DATE
          ) USING TEXTFILE WITH('text.delimiter'='|', 'timezone'='ASIA/Seoul') LOCATION '/path-to-table/'
          ```

          It will translate timestamp and time value by a specified time zone. I also added the detailed documentation about time zone property.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-65966314 In addition, I added the table property 'timezone'. You can use it in your ``CREATE TABLE`` statement as follows: ```sql CREATE EXTERNAL TABLE table1 ( t_timestamp TIMESTAMP, t_time TIME, t_date DATE ) USING TEXTFILE WITH('text.delimiter'='|', 'timezone'='ASIA/Seoul') LOCATION '/path-to-table/' ``` It will translate timestamp and time value by a specified time zone. I also added the detailed documentation about time zone property.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12685648/TAJO-1234_6.patch
          against master revision release-0.9.0-rc0-74-g95cf4b9.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 22 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 455 release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/533//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/533//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685648/TAJO-1234_6.patch against master revision release-0.9.0-rc0-74-g95cf4b9. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 22 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 256 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 455 release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core tajo-jdbc tajo-plan tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/533//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/533//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/533//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/290#discussion_r21434576

          — Diff: tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java —
          @@ -151,7 +150,7 @@ public final void testTimestampConstructor() {
          assertEquals(datum2, datum);

          for (int i = 0; i < 100; i++) {

          • TimeZone timeZone = TimeZone.getTimeZone("UTC");
            + TimeZone timeZone = TimeZone.getTimeZone("GMT");
              • End diff –

          How about using TajoConstants.UTC_TIMEZONE?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/290#discussion_r21434576 — Diff: tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java — @@ -151,7 +150,7 @@ public final void testTimestampConstructor() { assertEquals(datum2, datum); for (int i = 0; i < 100; i++) { TimeZone timeZone = TimeZone.getTimeZone("UTC"); + TimeZone timeZone = TimeZone.getTimeZone("GMT"); End diff – How about using TajoConstants.UTC_TIMEZONE?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-66032054

          Thanks @hyunsik

          +1 for the patch.

          All unit test cases finished successfully on three timezones such as Asia/Seoul, America/Toronto,Europe/Paris.

          After considering @jihoonson's comment, push it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-66032054 Thanks @hyunsik +1 for the patch. All unit test cases finished successfully on three timezones such as Asia/Seoul, America/Toronto,Europe/Paris. After considering @jihoonson's comment, push it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-66032354

          @blrunner, thanks for your testing.
          In my computer, unit tests failed due to another problem of my machine, so I couldn't verify the patch.
          The patch looks good to me, too.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-66032354 @blrunner, thanks for your testing. In my computer, unit tests failed due to another problem of my machine, so I couldn't verify the patch. The patch looks good to me, too.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/290#issuecomment-66033616

          Thank you all guys for the quick review.

          @jihoonson TajoConstants.UTC_TIMEZONE is used for a system default config. In contrast, the unit tests were written to test the behavior of different time zones. So, I'll change the constant name to SYSTEM_DEFAULT_TIMEZONE.

          I'll commit it shortly due to unit test failure. If there are further feedback, I'll reflect them later in another jira.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/290#issuecomment-66033616 Thank you all guys for the quick review. @jihoonson TajoConstants.UTC_TIMEZONE is used for a system default config. In contrast, the unit tests were written to test the behavior of different time zones. So, I'll change the constant name to SYSTEM_DEFAULT_TIMEZONE. I'll commit it shortly due to unit test failure. If there are further feedback, I'll reflect them later in another jira.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/290

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/290
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #126 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/126/)
          TAJO-1234: Rearrange timezone in date/time types. (hyunsik: rev facd1ddcc85a088ab8ba4e42dce2c99f6fe7e5de)

          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable2.sql
          • tajo-plan/src/main/proto/Plan.proto
          • tajo-common/src/main/java/org/apache/tajo/json/TimeZoneGsonSerdeAdapter.java
          • tajo-client/src/main/java/org/apache/tajo/jdbc/TajoMemoryResultSet.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
          • CHANGES
          • tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerializer.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/AvgDouble.java
          • tajo-common/src/main/java/org/apache/tajo/SessionVars.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/Lpad.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable1.sql
          • tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetBase.java
          • tajo-docs/src/main/sphinx/table_management.rst
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DatePartFromTime.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/CurrentDate.java
          • tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSet.java
          • tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result
          • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineDeserializer.java
          • tajo-core/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToTimestampText.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalTreeProtoDeserializer.java
          • tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DatePartFromTimestamp.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/Rpad.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/BTrim.java
          • tajo-docs/src/main/sphinx/table_management/csv.rst
          • tajo-plan/src/main/java/org/apache/tajo/plan/serder/PlanGsonHelper.java
          • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToCharTimestamp.java
          • tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java
          • tajo-common/src/main/java/org/apache/tajo/datum/Datum.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable3.sql
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java
          • tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/function/GeneralFunction.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java
          • tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/text/TextFieldSerializerDeserializer.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java
          • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
          • tajo-docs/src/main/sphinx/table_management/table_overview.rst
          • tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/RTrim.java
          • tajo-common/src/main/java/org/apache/tajo/OverridableConf.java
          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java
          • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/LTrim.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLDateTimeTypes.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql
          • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java
          • tajo-client/src/main/java/org/apache/tajo/jdbc/FetchResultSet.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestIntervalType.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
          • tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java
          • tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/RegexpReplace.java
          • tajo-core/src/main/java/org/apache/tajo/engine/json/CoreGsonHelper.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalTreeProtoSerializer.java
          • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoMetaDataResultSet.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql
          • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
          • tajo-common/src/main/java/org/apache/tajo/storage/StorageConstants.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #126 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/126/ ) TAJO-1234 : Rearrange timezone in date/time types. (hyunsik: rev facd1ddcc85a088ab8ba4e42dce2c99f6fe7e5de) tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable2.sql tajo-plan/src/main/proto/Plan.proto tajo-common/src/main/java/org/apache/tajo/json/TimeZoneGsonSerdeAdapter.java tajo-client/src/main/java/org/apache/tajo/jdbc/TajoMemoryResultSet.java tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java CHANGES tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerializer.java tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/AvgDouble.java tajo-common/src/main/java/org/apache/tajo/SessionVars.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/Lpad.java tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable1.sql tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetBase.java tajo-docs/src/main/sphinx/table_management.rst tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DatePartFromTime.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/CurrentDate.java tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSet.java tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineDeserializer.java tajo-core/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToTimestampText.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalTreeProtoDeserializer.java tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DatePartFromTimestamp.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/Rpad.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/BTrim.java tajo-docs/src/main/sphinx/table_management/csv.rst tajo-plan/src/main/java/org/apache/tajo/plan/serder/PlanGsonHelper.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToCharTimestamp.java tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java tajo-common/src/main/java/org/apache/tajo/datum/Datum.java tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable3.sql tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java tajo-common/src/main/java/org/apache/tajo/TajoConstants.java tajo-plan/src/main/java/org/apache/tajo/plan/function/GeneralFunction.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java tajo-storage/src/main/java/org/apache/tajo/storage/text/TextFieldSerializerDeserializer.java tajo-storage/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-docs/src/main/sphinx/table_management/table_overview.rst tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result tajo-core/src/main/java/org/apache/tajo/engine/function/string/RTrim.java tajo-common/src/main/java/org/apache/tajo/OverridableConf.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/LTrim.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLDateTimeTypes.java tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java tajo-client/src/main/java/org/apache/tajo/jdbc/FetchResultSet.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestIntervalType.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/RegexpReplace.java tajo-core/src/main/java/org/apache/tajo/engine/json/CoreGsonHelper.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalTreeProtoSerializer.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoMetaDataResultSet.java tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-common/src/main/java/org/apache/tajo/storage/StorageConstants.java tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #485 (See https://builds.apache.org/job/Tajo-master-build/485/)
          TAJO-1234: Rearrange timezone in date/time types. (hyunsik: rev facd1ddcc85a088ab8ba4e42dce2c99f6fe7e5de)

          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/RTrim.java
          • tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/LTrim.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/serder/PlanGsonHelper.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DatePartFromTime.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLDateTimeTypes.java
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/CurrentDate.java
          • tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result
          • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoMetaDataResultSet.java
          • tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetBase.java
          • tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java
          • CHANGES
          • tajo-plan/src/main/java/org/apache/tajo/plan/function/GeneralFunction.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
          • tajo-docs/src/main/sphinx/table_management.rst
          • tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable2.sql
          • tajo-storage/src/main/java/org/apache/tajo/storage/text/TextFieldSerializerDeserializer.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestIntervalType.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql
          • tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/Lpad.java
          • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
          • tajo-client/src/main/java/org/apache/tajo/jdbc/TajoMemoryResultSet.java
          • tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
          • tajo-core/src/main/java/org/apache/tajo/engine/json/CoreGsonHelper.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToCharTimestamp.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalTreeProtoDeserializer.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable1.sql
          • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
          • tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/BTrim.java
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java
          • tajo-core/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl
          • tajo-common/src/main/java/org/apache/tajo/json/TimeZoneGsonSerdeAdapter.java
          • tajo-docs/src/main/sphinx/table_management/table_overview.rst
          • tajo-common/src/main/java/org/apache/tajo/datum/Datum.java
          • tajo-common/src/main/java/org/apache/tajo/storage/StorageConstants.java
          • tajo-common/src/main/java/org/apache/tajo/SessionVars.java
          • tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result
          • tajo-plan/src/main/proto/Plan.proto
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/Rpad.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalTreeProtoSerializer.java
          • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/AvgDouble.java
          • tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToTimestampText.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineDeserializer.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java
          • tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DatePartFromTimestamp.java
          • tajo-common/src/main/java/org/apache/tajo/OverridableConf.java
          • tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
          • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerializer.java
          • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
          • tajo-core/src/main/java/org/apache/tajo/engine/function/string/RegexpReplace.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
          • tajo-client/src/main/java/org/apache/tajo/jdbc/FetchResultSet.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable3.sql
          • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java
          • tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java
          • tajo-docs/src/main/sphinx/table_management/csv.rst
          • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
          • tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSet.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #485 (See https://builds.apache.org/job/Tajo-master-build/485/ ) TAJO-1234 : Rearrange timezone in date/time types. (hyunsik: rev facd1ddcc85a088ab8ba4e42dce2c99f6fe7e5de) tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/RTrim.java tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable3.result tajo-core/src/main/java/org/apache/tajo/engine/function/string/LTrim.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/PlanGsonHelper.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DatePartFromTime.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLDateTimeTypes.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/CurrentDate.java tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable1.result tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoMetaDataResultSet.java tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetBase.java tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/function/GeneralFunction.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java tajo-docs/src/main/sphinx/table_management.rst tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable2.sql tajo-storage/src/main/java/org/apache/tajo/storage/text/TextFieldSerializerDeserializer.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestIntervalType.java tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_ddl.sql tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/Lpad.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-client/src/main/java/org/apache/tajo/jdbc/TajoMemoryResultSet.java tajo-common/src/main/java/org/apache/tajo/TajoConstants.java tajo-core/src/main/java/org/apache/tajo/engine/json/CoreGsonHelper.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToCharTimestamp.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalTreeProtoDeserializer.java tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable1.sql tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/BTrim.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java tajo-core/src/test/resources/dataset/TestSelectQuery/timezoned/table1.tbl tajo-common/src/main/java/org/apache/tajo/json/TimeZoneGsonSerdeAdapter.java tajo-docs/src/main/sphinx/table_management/table_overview.rst tajo-common/src/main/java/org/apache/tajo/datum/Datum.java tajo-common/src/main/java/org/apache/tajo/storage/StorageConstants.java tajo-common/src/main/java/org/apache/tajo/SessionVars.java tajo-core/src/test/resources/results/TestSelectQuery/testTimezonedTable2.result tajo-plan/src/main/proto/Plan.proto tajo-core/src/main/java/org/apache/tajo/engine/function/string/Rpad.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalTreeProtoSerializer.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/AvgDouble.java tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/ToTimestampText.java tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineDeserializer.java tajo-storage/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DatePartFromTimestamp.java tajo-common/src/main/java/org/apache/tajo/OverridableConf.java tajo-core/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerializer.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/RegexpReplace.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-client/src/main/java/org/apache/tajo/jdbc/FetchResultSet.java tajo-core/src/test/resources/queries/TestSelectQuery/testTimezonedTable3.sql tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java tajo-core/src/test/resources/queries/TestSelectQuery/datetime_table_timezoned_ddl.sql tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java tajo-docs/src/main/sphinx/table_management/csv.rst tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSet.java
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed.

          Show
          hyunsik Hyunsik Choi added a comment - committed.

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development