Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1180

digitValue should throw Exception when char is not in valid range

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      digitValue in TextUtils
      it returns numeric value for hex data.
      and. it should handle [0-9a-zA-Z].
      but it returns some digit for other ranges.
      so. I think it is better throw exception if it is not in valid range.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/246

        TAJO-1180: digitValue should throw Exception when char is not in valid range

        digitValue in TextUtils
        it returns numeric value for hex data.
        and. it should handle [0-9a-zA-Z].
        but it returns some digit for other ranges.
        so. I think it is better throw exception if it is not in valid range.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/fix_digitivalue

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/246.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #246


        commit 5d0c3d25929563f670a4f6bca0e8b92e4f85cd3e
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2014-11-15T16:49:10Z

        change digitValue to throw exception


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/246 TAJO-1180 : digitValue should throw Exception when char is not in valid range digitValue in TextUtils it returns numeric value for hex data. and. it should handle [0-9a-zA-Z] . but it returns some digit for other ranges. so. I think it is better throw exception if it is not in valid range. You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/fix_digitivalue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/246.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #246 commit 5d0c3d25929563f670a4f6bca0e8b92e4f85cd3e Author: clark.kang <clark.kang@kakao.com> Date: 2014-11-15T16:49:10Z change digitValue to throw exception
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eminency commented on the pull request:

        https://github.com/apache/tajo/pull/246#issuecomment-68669711

        +1

        I think it looks good for detecting unexpected error.

        Show
        githubbot ASF GitHub Bot added a comment - Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/246#issuecomment-68669711 +1 I think it looks good for detecting unexpected error.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/246#issuecomment-68783411

        +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/246#issuecomment-68783411 +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/246

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/246
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed to master branch. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed to master branch. Thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #173 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/173/)
        TAJO-1180: digitValue should throw Exception when char is not in valid range. (DaeMyung Kang via hyunsik) (hyunsik: rev 203a146b278a88853054bb6bd9ad7699e7268b8a)

        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/datum/protobuf/TextUtils.java
        • tajo-common/src/test/java/org/apache/tajo/datum/protobuf/TestTextUtils.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #173 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/173/ ) TAJO-1180 : digitValue should throw Exception when char is not in valid range. (DaeMyung Kang via hyunsik) (hyunsik: rev 203a146b278a88853054bb6bd9ad7699e7268b8a) CHANGES tajo-common/src/main/java/org/apache/tajo/datum/protobuf/TextUtils.java tajo-common/src/test/java/org/apache/tajo/datum/protobuf/TestTextUtils.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #534 (See https://builds.apache.org/job/Tajo-master-build/534/)
        TAJO-1180: digitValue should throw Exception when char is not in valid range. (DaeMyung Kang via hyunsik) (hyunsik: rev 203a146b278a88853054bb6bd9ad7699e7268b8a)

        • CHANGES
        • tajo-common/src/test/java/org/apache/tajo/datum/protobuf/TestTextUtils.java
        • tajo-common/src/main/java/org/apache/tajo/datum/protobuf/TextUtils.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #534 (See https://builds.apache.org/job/Tajo-master-build/534/ ) TAJO-1180 : digitValue should throw Exception when char is not in valid range. (DaeMyung Kang via hyunsik) (hyunsik: rev 203a146b278a88853054bb6bd9ad7699e7268b8a) CHANGES tajo-common/src/test/java/org/apache/tajo/datum/protobuf/TestTextUtils.java tajo-common/src/main/java/org/apache/tajo/datum/protobuf/TextUtils.java

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development