Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1173

Add size 8 instead of 4 For ServerName

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: TajoMaster
    • Labels:
      None

      Description

      In tajo-core/src/main/java/org/apache/tajo/master/cluster/ServerName.java.
      In getServerName, Creating StringBuilder With (hostName.length() + 4)

      but like below, it is short, so it call internally newCapacity() if port size is larger than 3

      name.append(hostName); //+hostName.length()
      name.append(SERVERNAME_SEPARATOR); //+1
      name.append(port); //port range is 0 <= port range <= 65535

      so this patch. prevent newCapacity() internally doing allocating proper size.

      but. It just change value from 4 to 8(to cover port range 65535)
      It passed testcases.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                charsyam DaeMyung Kang
                Reporter:
                charsyam DaeMyung Kang
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: