Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Storage
    • Labels:
      None

      Description

      Json file format is very common format in many web service applications. JSON file support is very desired feature for users who want to analysis web data. We also need to support this feature.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/181

        TAJO-1095: Implement Json file scanner.

        This is still on-going work. I'll improve its unit test.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1095

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/181.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #181


        commit f0aeb800b3879106d78ed91561c958e041d43daa
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-10-06T05:32:22Z

        TAJO-1095: Implement Json file scanner.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/181 TAJO-1095 : Implement Json file scanner. This is still on-going work. I'll improve its unit test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1095 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/181.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #181 commit f0aeb800b3879106d78ed91561c958e041d43daa Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-10-06T05:32:22Z TAJO-1095 : Implement Json file scanner.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/181#discussion_r18688360

        — Diff: tajo-core/src/main/java/org/apache/tajo/engine/optimizer/eval/EvalTreeOptimizer.java —
        @@ -70,6 +70,7 @@ public EvalNode optimize(LogicalPlanner.PlanContext context, EvalNode node) {

        EvalNode optimized = node;
        for (EvalTreeOptimizationRule rule : rules) {
        + LOG.info(node);
        — End diff –

        Is this a necessary log?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/181#discussion_r18688360 — Diff: tajo-core/src/main/java/org/apache/tajo/engine/optimizer/eval/EvalTreeOptimizer.java — @@ -70,6 +70,7 @@ public EvalNode optimize(LogicalPlanner.PlanContext context, EvalNode node) { EvalNode optimized = node; for (EvalTreeOptimizationRule rule : rules) { + LOG.info(node); — End diff – Is this a necessary log?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/181#discussion_r18688459

        — Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java —
        @@ -249,36 +249,45 @@ public Expr visitInsert(Context context, Stack<Expr> stack, Insert expr) throws

        if (child != null && child.getType() == OpType.Projection) {
        Projection projection = (Projection) child;

        • int projectColumnNum = projection.getNamedExprs().length;
        • if (expr.hasTargetColumns()) {
        • int targetColumnNum = expr.getTargetColumns().length;
          + boolean includeAsterisk = true;
        • if (targetColumnNum > projectColumnNum) { - context.state.addVerification("INSERT has more target columns than expressions"); - }

          else if (targetColumnNum < projectColumnNum)

          { - context.state.addVerification("INSERT has more expressions than target columns"); - }
        • } else {
        • if (expr.hasTableName()) {
        • String qualifiedName = expr.getTableName();
        • if (TajoConstants.EMPTY_STRING.equals(CatalogUtil.extractQualifier(expr.getTableName()))) { - qualifiedName = CatalogUtil.buildFQName(context.queryContext.getCurrentDatabase(), - expr.getTableName()); - }

          + for (NamedExpr namedExpr : projection.getNamedExprs()) {
          + includeAsterisk |= namedExpr.getExpr().getType() != OpType.Asterisk;

            • End diff –

        It seems that 'includeAsterisk' is always true, because the initial value is true, and some boolean values are ORed.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/181#discussion_r18688459 — Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java — @@ -249,36 +249,45 @@ public Expr visitInsert(Context context, Stack<Expr> stack, Insert expr) throws if (child != null && child.getType() == OpType.Projection) { Projection projection = (Projection) child; int projectColumnNum = projection.getNamedExprs().length; if (expr.hasTargetColumns()) { int targetColumnNum = expr.getTargetColumns().length; + boolean includeAsterisk = true; if (targetColumnNum > projectColumnNum) { - context.state.addVerification("INSERT has more target columns than expressions"); - } else if (targetColumnNum < projectColumnNum) { - context.state.addVerification("INSERT has more expressions than target columns"); - } } else { if (expr.hasTableName()) { String qualifiedName = expr.getTableName(); if (TajoConstants.EMPTY_STRING.equals(CatalogUtil.extractQualifier(expr.getTableName()))) { - qualifiedName = CatalogUtil.buildFQName(context.queryContext.getCurrentDatabase(), - expr.getTableName()); - } + for (NamedExpr namedExpr : projection.getNamedExprs()) { + includeAsterisk |= namedExpr.getExpr().getType() != OpType.Asterisk; End diff – It seems that 'includeAsterisk' is always true, because the initial value is true, and some boolean values are ORed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/181#discussion_r18688493

        — Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java —
        @@ -249,36 +249,45 @@ public Expr visitInsert(Context context, Stack<Expr> stack, Insert expr) throws

        if (child != null && child.getType() == OpType.Projection) {
        Projection projection = (Projection) child;

        • int projectColumnNum = projection.getNamedExprs().length;
        • if (expr.hasTargetColumns()) {
        • int targetColumnNum = expr.getTargetColumns().length;
          + boolean includeAsterisk = true;
        • if (targetColumnNum > projectColumnNum) { - context.state.addVerification("INSERT has more target columns than expressions"); - }

          else if (targetColumnNum < projectColumnNum)

          { - context.state.addVerification("INSERT has more expressions than target columns"); - }
        • } else {
        • if (expr.hasTableName()) {
        • String qualifiedName = expr.getTableName();
        • if (TajoConstants.EMPTY_STRING.equals(CatalogUtil.extractQualifier(expr.getTableName()))) { - qualifiedName = CatalogUtil.buildFQName(context.queryContext.getCurrentDatabase(), - expr.getTableName()); - }

          + for (NamedExpr namedExpr : projection.getNamedExprs())

          { + includeAsterisk |= namedExpr.getExpr().getType() != OpType.Asterisk; + }

          +
          + if (!includeAsterisk) {

            • End diff –

        Maybe we need to handle the case that the projection includes an asterisk. Will this case be handled in other issues?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/181#discussion_r18688493 — Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java — @@ -249,36 +249,45 @@ public Expr visitInsert(Context context, Stack<Expr> stack, Insert expr) throws if (child != null && child.getType() == OpType.Projection) { Projection projection = (Projection) child; int projectColumnNum = projection.getNamedExprs().length; if (expr.hasTargetColumns()) { int targetColumnNum = expr.getTargetColumns().length; + boolean includeAsterisk = true; if (targetColumnNum > projectColumnNum) { - context.state.addVerification("INSERT has more target columns than expressions"); - } else if (targetColumnNum < projectColumnNum) { - context.state.addVerification("INSERT has more expressions than target columns"); - } } else { if (expr.hasTableName()) { String qualifiedName = expr.getTableName(); if (TajoConstants.EMPTY_STRING.equals(CatalogUtil.extractQualifier(expr.getTableName()))) { - qualifiedName = CatalogUtil.buildFQName(context.queryContext.getCurrentDatabase(), - expr.getTableName()); - } + for (NamedExpr namedExpr : projection.getNamedExprs()) { + includeAsterisk |= namedExpr.getExpr().getType() != OpType.Asterisk; + } + + if (!includeAsterisk) { End diff – Maybe we need to handle the case that the projection includes an asterisk. Will this case be handled in other issues?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/181#discussion_r18688503

        — Diff: tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java —
        @@ -18,9 +18,11 @@

        package org.apache.tajo;

        +import com.google.common.base.Preconditions;
        — End diff –

        Please remove unused imports.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/181#discussion_r18688503 — Diff: tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java — @@ -18,9 +18,11 @@ package org.apache.tajo; +import com.google.common.base.Preconditions; — End diff – Please remove unused imports.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/181#issuecomment-58613139

        Hi Hyunsik.
        Thanks for your contribution. This is a truly necessary feature.
        JSonScanner looks good, and a relevant test was successfully passed.
        However, in PreLogicalPlanVerifier, I suspect that some lines can occur potential problems. I left some comments related to them.
        In addition, TestTablePartitions.testColumnPartitionedTableWithSmallerExpressions1() and TestTablePartitions.testColumnPartitionedTableWithSmallerExpressions2() fails. Please check them.

        Thanks.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/181#issuecomment-58613139 Hi Hyunsik. Thanks for your contribution. This is a truly necessary feature. JSonScanner looks good, and a relevant test was successfully passed. However, in PreLogicalPlanVerifier, I suspect that some lines can occur potential problems. I left some comments related to them. In addition, TestTablePartitions.testColumnPartitionedTableWithSmallerExpressions1() and TestTablePartitions.testColumnPartitionedTableWithSmallerExpressions2() fails. Please check them. Thanks.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/181#issuecomment-64819022

        I rebased and reflected your comments. Also, I changed the patch to use the pluggable text line serde (https://issues.apache.org/jira/browse/TAJO-1209) which has been recently added.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/181#issuecomment-64819022 I rebased and reflected your comments. Also, I changed the patch to use the pluggable text line serde ( https://issues.apache.org/jira/browse/TAJO-1209 ) which has been recently added.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/181#issuecomment-64839655

        updated.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/181#issuecomment-64839655 updated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/181#discussion_r21014823

        — Diff: tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java —
        @@ -0,0 +1,222 @@
        +/**
        + * Licensed to the Apache Software Foundation (ASF) under one
        + * or more contributor license agreements. See the NOTICE file
        + * distributed with this work for additional information
        + * regarding copyright ownership. The ASF licenses this file
        + * to you under the Apache License, Version 2.0 (the
        + * "License"); you may not use this file except in compliance
        + * with the License. You may obtain a copy of the License at
        + *
        + * http://www.apache.org/licenses/LICENSE-2.0
        + *
        + * Unless required by applicable law or agreed to in writing, software
        + * distributed under the License is distributed on an "AS IS" BASIS,
        + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        + * See the License for the specific language governing permissions and
        + * limitations under the License.
        + */
        +
        +package org.apache.tajo.storage.json;
        +
        +
        +import io.netty.buffer.ByteBuf;
        +import net.minidev.json.JSONArray;
        +import net.minidev.json.JSONObject;
        +import net.minidev.json.parser.JSONParser;
        +import org.apache.tajo.catalog.Schema;
        +import org.apache.tajo.catalog.SchemaUtil;
        +import org.apache.tajo.catalog.TableMeta;
        +import org.apache.tajo.common.TajoDataTypes.Type;
        +import org.apache.tajo.common.exception.NotImplementedException;
        +import org.apache.tajo.datum.DatumFactory;
        +import org.apache.tajo.datum.NullDatum;
        +import org.apache.tajo.datum.protobuf.ProtobufJsonFormat;
        +import org.apache.tajo.storage.Tuple;
        +import org.apache.tajo.storage.text.TextLineDeserializer;
        +
        +import java.io.IOException;
        +import java.util.Iterator;
        +
        +public class JsonLineDeserializer extends TextLineDeserializer {
        + private static ProtobufJsonFormat protobufJsonFormat = ProtobufJsonFormat.getInstance();
        — End diff –

        Could you remove this line ? It seems to unused code

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/181#discussion_r21014823 — Diff: tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java — @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.tajo.storage.json; + + +import io.netty.buffer.ByteBuf; +import net.minidev.json.JSONArray; +import net.minidev.json.JSONObject; +import net.minidev.json.parser.JSONParser; +import org.apache.tajo.catalog.Schema; +import org.apache.tajo.catalog.SchemaUtil; +import org.apache.tajo.catalog.TableMeta; +import org.apache.tajo.common.TajoDataTypes.Type; +import org.apache.tajo.common.exception.NotImplementedException; +import org.apache.tajo.datum.DatumFactory; +import org.apache.tajo.datum.NullDatum; +import org.apache.tajo.datum.protobuf.ProtobufJsonFormat; +import org.apache.tajo.storage.Tuple; +import org.apache.tajo.storage.text.TextLineDeserializer; + +import java.io.IOException; +import java.util.Iterator; + +public class JsonLineDeserializer extends TextLineDeserializer { + private static ProtobufJsonFormat protobufJsonFormat = ProtobufJsonFormat.getInstance(); — End diff – Could you remove this line ? It seems to unused code
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/181#discussion_r21016228

        — Diff: tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java —
        @@ -0,0 +1,131 @@
        +/**
        + * Licensed to the Apache Software Foundation (ASF) under one
        + * or more contributor license agreements. See the NOTICE file
        + * distributed with this work for additional information
        + * regarding copyright ownership. The ASF licenses this file
        + * to you under the Apache License, Version 2.0 (the
        + * "License"); you may not use this file except in compliance
        + * with the License. You may obtain a copy of the License at
        + *
        + * http://www.apache.org/licenses/LICENSE-2.0
        + *
        + * Unless required by applicable law or agreed to in writing, software
        + * distributed under the License is distributed on an "AS IS" BASIS,
        + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        + * See the License for the specific language governing permissions and
        + * limitations under the License.
        + */
        +
        +package org.apache.tajo.storage.json;
        +
        +
        +import net.minidev.json.JSONObject;
        +import org.apache.tajo.catalog.Schema;
        +import org.apache.tajo.catalog.SchemaUtil;
        +import org.apache.tajo.catalog.TableMeta;
        +import org.apache.tajo.common.TajoDataTypes.Type;
        +import org.apache.tajo.common.exception.NotImplementedException;
        +import org.apache.tajo.datum.ProtobufDatum;
        +import org.apache.tajo.datum.protobuf.ProtobufJsonFormat;
        +import org.apache.tajo.storage.Tuple;
        +import org.apache.tajo.storage.text.TextLineSerDe;
        +import org.apache.tajo.storage.text.TextLineSerializer;
        +
        +import java.io.IOException;
        +import java.io.OutputStream;
        +
        +public class JsonLineSerializer extends TextLineSerializer {
        + private static ProtobufJsonFormat protobufJsonFormat = ProtobufJsonFormat.getInstance();
        +
        + private Type [] types;
        + private String [] simpleNames;
        + private int columnNum;
        +
        +
        + public JsonLineSerializer(Schema schema, TableMeta meta)

        { + super(schema, meta); + }

        +
        + @Override
        + public void init()

        { + types = SchemaUtil.toTypes(schema); + simpleNames = SchemaUtil.toSimpleNames(schema); + columnNum = schema.size(); + }

        +
        + @Override
        + public int serialize(OutputStream out, Tuple input) throws IOException {
        + JSONObject jsonObject = new JSONObject();
        +
        + for (int i = 0; i < columnNum; i++) {
        + if (input.isNull)

        { + continue; + }

        +
        + String fieldName = simpleNames[i];
        + Type type = types[i];
        +
        + switch (type)

        { + + case BOOLEAN: + jsonObject.put(fieldName, input.getBool(i)); + break; + + case INT1: + case INT2: + jsonObject.put(fieldName, input.getInt2(i)); + break; + + case INT4: + jsonObject.put(fieldName, input.getInt4(i)); + break; + + case INT8: + jsonObject.put(fieldName, input.getInt8(i)); + break; + + case FLOAT4: + jsonObject.put(fieldName, input.getFloat4(i)); + break; + + case FLOAT8: + jsonObject.put(fieldName, input.getFloat8(i)); + break; + + case CHAR: + case TEXT: + case VARCHAR: + case INET4: + case TIMESTAMP: + case DATE: + case TIME: + case INTERVAL: + jsonObject.put(fieldName, input.getText(i)); + break; + + case BIT: + case BINARY: + case BLOB: + case VARBINARY: + jsonObject.put(fieldName, input.getBytes(i)); + break; + + case NULL_TYPE: + break; + + default: + throw new NotImplementedException(types[i].name() + " is not supported."); + }

        + }
        +
        + String jsonStr = jsonObject.toJSONString();
        + byte [] jsonBytes = jsonStr.getBytes();
        — End diff –

        Could you add charset to UTF8?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/181#discussion_r21016228 — Diff: tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java — @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.tajo.storage.json; + + +import net.minidev.json.JSONObject; +import org.apache.tajo.catalog.Schema; +import org.apache.tajo.catalog.SchemaUtil; +import org.apache.tajo.catalog.TableMeta; +import org.apache.tajo.common.TajoDataTypes.Type; +import org.apache.tajo.common.exception.NotImplementedException; +import org.apache.tajo.datum.ProtobufDatum; +import org.apache.tajo.datum.protobuf.ProtobufJsonFormat; +import org.apache.tajo.storage.Tuple; +import org.apache.tajo.storage.text.TextLineSerDe; +import org.apache.tajo.storage.text.TextLineSerializer; + +import java.io.IOException; +import java.io.OutputStream; + +public class JsonLineSerializer extends TextLineSerializer { + private static ProtobufJsonFormat protobufJsonFormat = ProtobufJsonFormat.getInstance(); + + private Type [] types; + private String [] simpleNames; + private int columnNum; + + + public JsonLineSerializer(Schema schema, TableMeta meta) { + super(schema, meta); + } + + @Override + public void init() { + types = SchemaUtil.toTypes(schema); + simpleNames = SchemaUtil.toSimpleNames(schema); + columnNum = schema.size(); + } + + @Override + public int serialize(OutputStream out, Tuple input) throws IOException { + JSONObject jsonObject = new JSONObject(); + + for (int i = 0; i < columnNum; i++) { + if (input.isNull ) { + continue; + } + + String fieldName = simpleNames [i] ; + Type type = types [i] ; + + switch (type) { + + case BOOLEAN: + jsonObject.put(fieldName, input.getBool(i)); + break; + + case INT1: + case INT2: + jsonObject.put(fieldName, input.getInt2(i)); + break; + + case INT4: + jsonObject.put(fieldName, input.getInt4(i)); + break; + + case INT8: + jsonObject.put(fieldName, input.getInt8(i)); + break; + + case FLOAT4: + jsonObject.put(fieldName, input.getFloat4(i)); + break; + + case FLOAT8: + jsonObject.put(fieldName, input.getFloat8(i)); + break; + + case CHAR: + case TEXT: + case VARCHAR: + case INET4: + case TIMESTAMP: + case DATE: + case TIME: + case INTERVAL: + jsonObject.put(fieldName, input.getText(i)); + break; + + case BIT: + case BINARY: + case BLOB: + case VARBINARY: + jsonObject.put(fieldName, input.getBytes(i)); + break; + + case NULL_TYPE: + break; + + default: + throw new NotImplementedException(types[i].name() + " is not supported."); + } + } + + String jsonStr = jsonObject.toJSONString(); + byte [] jsonBytes = jsonStr.getBytes(); — End diff – Could you add charset to UTF8?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/181#issuecomment-64858020

        Thank you for your comments. I reflected your comments and rebased the patch.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/181#issuecomment-64858020 Thank you for your comments. I reflected your comments and rebased the patch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/181#issuecomment-64865141

        +1
        Looks great to me!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/181#issuecomment-64865141 +1 Looks great to me!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/181

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/181
        Hide
        hyunsik Hyunsik Choi added a comment -

        I just committed the latest patch to master branch. Thank you for the reviews!

        Show
        hyunsik Hyunsik Choi added a comment - I just committed the latest patch to master branch. Thank you for the reviews!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #471 (See https://builds.apache.org/job/Tajo-master-build/471/)
        TAJO-1095: Implement Json file scanner. (hyunsik: rev cd38dffb908a3959472f5ddb705db71d0e48ad89)

        • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerDe.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerializer.java
        • tajo-storage/src/test/resources/testVariousTypes.avsc
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineDeserializer.java
        • tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/TextFieldSerializerDeserializer.java
        • tajo-storage/src/test/resources/dataset/TestJsonSerDe/testVariousType.json
        • tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
        • tajo-common/src/main/java/org/apache/tajo/storage/StorageConstants.java
        • tajo-storage/src/test/resources/storage-default.xml
        • CHANGES
        • tajo-storage/src/test/java/org/apache/tajo/storage/json/TestJsonSerDe.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/TextLineDeserializer.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SchemaUtil.java
        • tajo-storage/src/main/resources/storage-default.xml
        • tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerDe.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        • tajo-storage/pom.xml
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #471 (See https://builds.apache.org/job/Tajo-master-build/471/ ) TAJO-1095 : Implement Json file scanner. (hyunsik: rev cd38dffb908a3959472f5ddb705db71d0e48ad89) tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerDe.java tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerializer.java tajo-storage/src/test/resources/testVariousTypes.avsc tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineDeserializer.java tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java tajo-storage/src/main/java/org/apache/tajo/storage/text/TextFieldSerializerDeserializer.java tajo-storage/src/test/resources/dataset/TestJsonSerDe/testVariousType.json tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java tajo-common/src/main/java/org/apache/tajo/storage/StorageConstants.java tajo-storage/src/test/resources/storage-default.xml CHANGES tajo-storage/src/test/java/org/apache/tajo/storage/json/TestJsonSerDe.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-storage/src/main/java/org/apache/tajo/storage/text/TextLineDeserializer.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SchemaUtil.java tajo-storage/src/main/resources/storage-default.xml tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerDe.java tajo-storage/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java tajo-storage/pom.xml tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #112 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/112/)
        TAJO-1095: Implement Json file scanner. (hyunsik: rev cd38dffb908a3959472f5ddb705db71d0e48ad89)

        • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerializer.java
        • tajo-storage/src/main/resources/storage-default.xml
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerDe.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SchemaUtil.java
        • tajo-storage/src/test/resources/testVariousTypes.avsc
        • tajo-storage/src/test/resources/storage-default.xml
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/TextLineDeserializer.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/json/TestJsonSerDe.java
        • CHANGES
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-storage/pom.xml
        • tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerDe.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineDeserializer.java
        • tajo-common/src/main/java/org/apache/tajo/storage/StorageConstants.java
        • tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
        • tajo-storage/src/test/resources/dataset/TestJsonSerDe/testVariousType.json
        • tajo-storage/src/main/java/org/apache/tajo/storage/text/TextFieldSerializerDeserializer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #112 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/112/ ) TAJO-1095 : Implement Json file scanner. (hyunsik: rev cd38dffb908a3959472f5ddb705db71d0e48ad89) tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerializer.java tajo-storage/src/main/resources/storage-default.xml tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineSerDe.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SchemaUtil.java tajo-storage/src/test/resources/testVariousTypes.avsc tajo-storage/src/test/resources/storage-default.xml tajo-storage/src/main/java/org/apache/tajo/storage/text/TextLineDeserializer.java tajo-storage/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java tajo-storage/src/test/java/org/apache/tajo/storage/json/TestJsonSerDe.java CHANGES tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-storage/pom.xml tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineSerDe.java tajo-storage/src/main/java/org/apache/tajo/storage/text/CSVLineDeserializer.java tajo-common/src/main/java/org/apache/tajo/storage/StorageConstants.java tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java tajo-storage/src/test/resources/dataset/TestJsonSerDe/testVariousType.json tajo-storage/src/main/java/org/apache/tajo/storage/text/TextFieldSerializerDeserializer.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development