Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1034

Reduce Explicit Use of JVM Internal Class

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Worker
    • Labels:
      None

      Description

      WorkerHeartbeatService use the JVM internal class for getting the physical memory size of workers which are running on. These platform-specific interfaces are registered in the Platform MBeanServer, and obtaining these interfaces via Platform MBeanServer may reduce the use of JVM internal classes.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #357 (See https://builds.apache.org/job/Tajo-master-build/357/)
        TAJO-1034: Reduce Explicit Use of JVM Internal Class. (Jihun Kang via hyunsik) (hyunsik: rev 3a3850a296e8fc4b08be410bc089b68ede681e82)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #357 (See https://builds.apache.org/job/Tajo-master-build/357/ ) TAJO-1034 : Reduce Explicit Use of JVM Internal Class. (Jihun Kang via hyunsik) (hyunsik: rev 3a3850a296e8fc4b08be410bc089b68ede681e82) CHANGES tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        I've just committed your patch to master branch. Thank you for your contribution.

        Show
        hyunsik Hyunsik Choi added a comment - I've just committed your patch to master branch. Thank you for your contribution.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks good to me. if there is no objection until tomorrow, I'll commit it.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks good to me. if there is no objection until tomorrow, I'll commit it.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12668219/platform_mbeanserver_draft.patch
        against master revision 4efb45b.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 211 new Findbugs (version 2.0.3) warnings.

        -1 release audit. The applied patch generated 102 release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/488//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/488//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/488//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/488//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12668219/platform_mbeanserver_draft.patch against master revision 4efb45b. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 211 new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 102 release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/488//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/488//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/488//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/488//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Hi Jihun,

        Thank you for your contribution. I'll review it soon.
        Also, I've just added you as a contributor. Later, feel free to assign yourself in any jira issue.

        Show
        hyunsik Hyunsik Choi added a comment - Hi Jihun, Thank you for your contribution. I'll review it soon. Also, I've just added you as a contributor. Later, feel free to assign yourself in any jira issue.

          People

          • Assignee:
            ykrips Jihun Kang
            Reporter:
            ykrips Jihun Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development