Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1017

TajoConf misuses read & write locks in some functions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      In TajoConf, setCurrentTimeZone and setDateOrder are using readLock for concurrency control although writeLock should be used.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #350 (See https://builds.apache.org/job/Tajo-master-build/350/)
        TAJO-1017: TajoConf misuses read & write locks in some functions. (Mai Hai Thanh via hyunsik) (hyunsik: rev 0e43627440e034b28f85fd91fb5b0286e23a0299)

        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #350 (See https://builds.apache.org/job/Tajo-master-build/350/ ) TAJO-1017 : TajoConf misuses read & write locks in some functions. (Mai Hai Thanh via hyunsik) (hyunsik: rev 0e43627440e034b28f85fd91fb5b0286e23a0299) tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java CHANGES
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed the patch to master branch. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed the patch to master branch. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/130

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/130
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/130#issuecomment-54411814

        +1
        The fix looks straightforward.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/130#issuecomment-54411814 +1 The fix looks straightforward.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user mhthanh opened a pull request:

        https://github.com/apache/tajo/pull/130

        TAJO-1017: TajoConf misuses read & write locks in some functions

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/mhthanh/tajo Tajo-1017

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/130.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #130


        commit 919812d4fe6debdcdcb45860635f89e73a758d4b
        Author: mhthanh <maihaithanh@gmail.com>
        Date: 2014-09-03T07:40:50Z

        Fixed misused locks in TajoConf


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user mhthanh opened a pull request: https://github.com/apache/tajo/pull/130 TAJO-1017 : TajoConf misuses read & write locks in some functions You can merge this pull request into a Git repository by running: $ git pull https://github.com/mhthanh/tajo Tajo-1017 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #130 commit 919812d4fe6debdcdcb45860635f89e73a758d4b Author: mhthanh <maihaithanh@gmail.com> Date: 2014-09-03T07:40:50Z Fixed misused locks in TajoConf
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1 for this issue.

        Show
        hyunsik Hyunsik Choi added a comment - +1 for this issue.

          People

          • Assignee:
            mhthanh Mai Hai Thanh
            Reporter:
            mhthanh Mai Hai Thanh
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development