Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      This patch includes de/serialization classes for EvalNode.

      This patch also inserts an unit test code to ExprTestBase to verify all eval nodes used in all unit tests inherented from ExprTestBase.

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        Additionally, I refactored EvalNode to have childNum() and getChild(idx) to make eval node traverse easier.

        Show
        hyunsik Hyunsik Choi added a comment - Additionally, I refactored EvalNode to have childNum() and getChild(idx) to make eval node traverse easier.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/118

        TAJO-1008: Protocol buffer De/Serialization for EvalNode.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1008

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/118.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #118


        commit ade69f784e2369aa2f6950ce4f95dd316f4526e3
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-08-15T13:51:40Z

        TAJO-1008: Protocol buffer De/Serialization for EvalNode.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/118 TAJO-1008 : Protocol buffer De/Serialization for EvalNode. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1008 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/118.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #118 commit ade69f784e2369aa2f6950ce4f95dd316f4526e3 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-08-15T13:51:40Z TAJO-1008 : Protocol buffer De/Serialization for EvalNode.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/118#issuecomment-52415124

        refactored some methods and variables.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/118#issuecomment-52415124 refactored some methods and variables.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/118#issuecomment-52471415

        I've added more comments.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/118#issuecomment-52471415 I've added more comments.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/118#issuecomment-52659796

        rebased.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/118#issuecomment-52659796 rebased.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/118#issuecomment-52733957

        +1
        Looks great to me. I've verified 'mvn clean install'.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/118#issuecomment-52733957 +1 Looks great to me. I've verified 'mvn clean install'.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/118#issuecomment-52735254

        committed.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/118#issuecomment-52735254 committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik closed the pull request at:

        https://github.com/apache/tajo/pull/118

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik closed the pull request at: https://github.com/apache/tajo/pull/118
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #342 (See https://builds.apache.org/job/Tajo-master-build/342/)
        TAJO-1008: Protocol buffer De/Serialization for EvalNode. (hyunsik: rev 49d52553c5e4ef37a6af4605befbe36b0dd36c3c)

        • tajo-storage/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestKeyValueSet.java
        • tajo-common/src/main/java/org/apache/tajo/util/BitArray.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashBasedColPartitionStoreExec.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/FileAppender.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java
        • tajo-common/src/main/java/org/apache/tajo/OverridableConf.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/Appender.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoGetConf.java
        • tajo-core/src/main/java/org/apache/tajo/master/session/Session.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java
        • tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java
        • CHANGES
          Revert "TAJO-1008: Protocol buffer De/Serialization for EvalNode." (hyunsik: rev 2d6bff7e8ef2ca2a7dff39c70383f30b2e06e055)
        • tajo-common/src/main/java/org/apache/tajo/OverridableConf.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/Appender.java
        • tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java
        • tajo-storage/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashBasedColPartitionStoreExec.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
        • tajo-core/src/main/java/org/apache/tajo/master/session/Session.java
        • CHANGES
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestKeyValueSet.java
        • tajo-common/src/main/java/org/apache/tajo/util/BitArray.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/FileAppender.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoGetConf.java
          TAJO-1008: Protocol buffer De/Serialization for EvalNode. (hyunsik: rev ea5ce54d812ac38dc23683c48d0ca24fb122a7ba)
        • tajo-core/src/main/java/org/apache/tajo/engine/plan/EvalTreeProtoSerializer.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/RowConstantEval.java
        • tajo-core/src/main/proto/Plan.proto
        • CHANGES
        • tajo-core/pom.xml
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/EvalNode.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/EvalType.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/FunctionEval.java
        • tajo-common/src/main/java/org/apache/tajo/datum/Datum.java
        • tajo-core/src/main/java/org/apache/tajo/engine/plan/EvalTreeProtoDeserializer.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/BetweenPredicateEval.java
        • tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/AlgebraicUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/BinaryEval.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/UnaryEval.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/CaseWhenEval.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/EvalTreeUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/SimpleEvalNodeVisitor.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/FieldEval.java
        • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTree.java
        • tajo-core/src/main/java/org/apache/tajo/engine/eval/ConstEval.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #342 (See https://builds.apache.org/job/Tajo-master-build/342/ ) TAJO-1008 : Protocol buffer De/Serialization for EvalNode. (hyunsik: rev 49d52553c5e4ef37a6af4605befbe36b0dd36c3c) tajo-storage/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestKeyValueSet.java tajo-common/src/main/java/org/apache/tajo/util/BitArray.java tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashBasedColPartitionStoreExec.java tajo-storage/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java tajo-storage/src/main/java/org/apache/tajo/storage/FileAppender.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-storage/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java tajo-common/src/main/java/org/apache/tajo/OverridableConf.java tajo-storage/src/main/java/org/apache/tajo/storage/Appender.java tajo-client/src/main/java/org/apache/tajo/client/TajoGetConf.java tajo-core/src/main/java/org/apache/tajo/master/session/Session.java tajo-storage/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java CHANGES Revert " TAJO-1008 : Protocol buffer De/Serialization for EvalNode." (hyunsik: rev 2d6bff7e8ef2ca2a7dff39c70383f30b2e06e055) tajo-common/src/main/java/org/apache/tajo/OverridableConf.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-storage/src/main/java/org/apache/tajo/storage/Appender.java tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java tajo-storage/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashBasedColPartitionStoreExec.java tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java tajo-storage/src/main/java/org/apache/tajo/storage/thirdparty/parquet/ParquetWriter.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java tajo-core/src/main/java/org/apache/tajo/master/session/Session.java CHANGES tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestKeyValueSet.java tajo-common/src/main/java/org/apache/tajo/util/BitArray.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java tajo-storage/src/main/java/org/apache/tajo/storage/thirdparty/parquet/InternalParquetRecordWriter.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java tajo-storage/src/main/java/org/apache/tajo/storage/FileAppender.java tajo-storage/src/main/java/org/apache/tajo/storage/parquet/ParquetAppender.java tajo-client/src/main/java/org/apache/tajo/client/TajoGetConf.java TAJO-1008 : Protocol buffer De/Serialization for EvalNode. (hyunsik: rev ea5ce54d812ac38dc23683c48d0ca24fb122a7ba) tajo-core/src/main/java/org/apache/tajo/engine/plan/EvalTreeProtoSerializer.java tajo-core/src/main/java/org/apache/tajo/engine/eval/RowConstantEval.java tajo-core/src/main/proto/Plan.proto CHANGES tajo-core/pom.xml tajo-core/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java tajo-core/src/main/java/org/apache/tajo/engine/eval/EvalNode.java tajo-core/src/main/java/org/apache/tajo/engine/eval/EvalType.java tajo-core/src/main/java/org/apache/tajo/engine/eval/FunctionEval.java tajo-common/src/main/java/org/apache/tajo/datum/Datum.java tajo-core/src/main/java/org/apache/tajo/engine/plan/EvalTreeProtoDeserializer.java tajo-core/src/main/java/org/apache/tajo/engine/eval/BetweenPredicateEval.java tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core/src/main/java/org/apache/tajo/engine/eval/AlgebraicUtil.java tajo-core/src/main/java/org/apache/tajo/engine/eval/BinaryEval.java tajo-core/src/main/java/org/apache/tajo/engine/eval/UnaryEval.java tajo-core/src/main/java/org/apache/tajo/engine/eval/CaseWhenEval.java tajo-core/src/main/java/org/apache/tajo/engine/eval/EvalTreeUtil.java tajo-core/src/main/java/org/apache/tajo/engine/eval/SimpleEvalNodeVisitor.java tajo-core/src/main/java/org/apache/tajo/engine/eval/FieldEval.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTree.java tajo-core/src/main/java/org/apache/tajo/engine/eval/ConstEval.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development