[SYSTEMDS-2180] Fuse all heuristic failing for kmeans tests w/o rewrites

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: SystemML 1.1
• Epic Link: Code generation for operator fusion v3
• Assignee: Janardhan Pulivarthi
• Reporter: Matthias Boehm
• Created: 09/Mar/18 03:24
• Updated: 09/Mar/18 20:14
• Resolved: 09/Mar/18 20:14

Description

The following invalid generated source code (see wrong indexing on main input and scalar operations over vector side inputs)

public final class TMP78 extends SpoofRowwise { 
  public TMP78() {
    super(RowType.FULL_AGG, -1, false, 0);
  }
  protected void genexec(double[] a, int ai, SideInput[] b, double[] scalars, double[] c, int ci, int len, int rix) { 
    double TMP74 = getValue(a, 3, rix, 1-1);
    double TMP75 = b[0].values(rix) * TMP74;
    c[0] += TMP75;
  }
  protected void genexec(double[] avals, int[] aix, int ai, SideInput[] b, double[] scalars, double[] c, int ci, int alen, int len, int rix) { 
    double TMP76 = getValue(avals, aix, ai, alen, 1-1);
    double TMP77 = b[0].values(rix) * TMP76;
    c[0] += TMP77;
  }
}

cause the following issue

org.apache.sysml.runtime.DMLRuntimeException: org.apache.sysml.runtime.DMLRuntimeException: Failed to compile class codegen.TMP78.
	at org.apache.sysml.hops.codegen.SpoofCompiler.optimize(SpoofCompiler.java:452)
	at org.apache.sysml.hops.recompile.Recompiler.recompile(Recompiler.java:376)
	at org.apache.sysml.hops.recompile.Recompiler.recompileHopsDag(Recompiler.java:163)
	at org.apache.sysml.hops.codegen.SpoofCompiler.generateCodeFromHopDAGsToInst(SpoofCompiler.java:315)
	at org.apache.sysml.hops.codegen.SpoofCompiler.generateCodeFromProgramBlock(SpoofCompiler.java:294)
	at org.apache.sysml.hops.codegen.SpoofCompiler.generateCodeFromProgramBlock(SpoofCompiler.java:274)
	at org.apache.sysml.hops.codegen.SpoofCompiler.generateCode(SpoofCompiler.java:200)
	at org.apache.sysml.parser.DMLTranslator.codgenHopsDAG(DMLTranslator.java:308)
	at org.apache.sysml.parser.DMLTranslator.getRuntimeProgram(DMLTranslator.java:451)
	at org.apache.sysml.api.DMLScript.execute(DMLScript.java:732)
	at org.apache.sysml.api.DMLScript.executeScript(DMLScript.java:525)
	at org.apache.sysml.api.DMLScript.main(DMLScript.java:252)
	at org.apache.sysml.test.integration.AutomatedTestBase.runTest(AutomatedTestBase.java:1222)
	at org.apache.sysml.test.integration.functions.codegenalg.AlgorithmKMeans.runKMeansTest(AlgorithmKMeans.java:342)
	at org.apache.sysml.test.integration.functions.codegenalg.AlgorithmKMeans.testKMeansSparseMulSingleCPFuseAll(AlgorithmKMeans.java:205)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
Caused by: org.apache.sysml.runtime.DMLRuntimeException: Failed to compile class codegen.TMP78.
	at org.apache.sysml.runtime.codegen.CodegenUtils.compileClassJanino(CodegenUtils.java:197)
	at org.apache.sysml.runtime.codegen.CodegenUtils.compileClass(CodegenUtils.java:82)
	at org.apache.sysml.hops.codegen.SpoofCompiler.optimize(SpoofCompiler.java:416)
	... 39 more
Caused by: org.codehaus.commons.compiler.CompileException: Line 14, Column 38: Binary numeric promotion not possible on types "double[]" and "double"
	at org.codehaus.janino.UnitCompiler.compileError(UnitCompiler.java:11004)
	at org.codehaus.janino.UnitCompiler.binaryNumericPromotionType(UnitCompiler.java:10237)
	at org.codehaus.janino.UnitCompiler.binaryNumericPromotion(UnitCompiler.java:10206)
	at org.codehaus.janino.UnitCompiler.binaryNumericPromotion(UnitCompiler.java:10180)
	at org.codehaus.janino.UnitCompiler.compileArithmeticOperation(UnitCompiler.java:6865)
	at org.codehaus.janino.UnitCompiler.compileGet2(UnitCompiler.java:4367)
	at org.codehaus.janino.UnitCompiler.access$6900(UnitCompiler.java:206)
	at org.codehaus.janino.UnitCompiler$12.visitBinaryOperation(UnitCompiler.java:3768)
	at org.codehaus.janino.UnitCompiler$12.visitBinaryOperation(UnitCompiler.java:3762)
	at org.codehaus.janino.Java$BinaryOperation.accept(Java.java:4155)
	at org.codehaus.janino.UnitCompiler.compileGet(UnitCompiler.java:3762)
	at org.codehaus.janino.UnitCompiler.compileGetValue(UnitCompiler.java:4933)