Uploaded image for project: 'SystemDS'
  1. SystemDS
  2. SYSTEMDS-2166

Reversed print ordering after function inlining

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • SystemML 1.1
    • None
    • None

    Description

      With SystemML 1.1 a number of new rewrites were introduced that merge sequences of statement blocks which appear after branch removal and function inlining. Although this greatly improves performance for certain workloads, it might lead to a reordering of operations without dependencies (such as prints) that end up in the consolidated DAG. SYSTEMML-2050 tried to address this by ordering of prints by their line numbers. Unfortunately, this works only in certain situations because after function lining the print line numbers do not correspond with the order of the original function calls.

      This task aims to resolve this behavior which might be confusing. There two possible approaches: either (1) assign artificial line numbers or positions during function lining and statement block merge, or (2) merge the DAG roots in order to their sequence. The second approach seems more appropriate because it also leaves the other operations in order, not just prints.

      Attachments

        Issue Links

          Activity

            People

              mboehm7 Matthias Boehm
              mboehm7 Matthias Boehm
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: