Uploaded image for project: 'Syncope'
  1. Syncope
  2. SYNCOPE-409

Allow notifications with empty about field

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.1.3
    • 1.1.4, 1.2.0-M1
    • console, core
    • None

    Description

      Currently, when one creates a new notification in Syncope, one is forced to enter a user search condition in the "About" tab that allows to restrict the notifications to specific users. IMO this is not always necessary - it should also be possible to leave the field empty such that the notification is sent for all users.

      Allowing the Notification.about field to be empty would also improve performance in this case, as an unnecessary search query to the database can be avoided. This is especially relevant for MySQL, as we observed full table scan behaviour for queries executed by AttributableSearchDAOImpl.matches() (called by NotificationManager) for even very simple search conditions.

      Attachments

        1. syncopeNotificationsEmptyAbout.patch
          11 kB
          Guido Wimmel
        2. syncopeNotificationsEmptyAbout.patch
          8 kB
          Guido Wimmel

        Activity

          People

            ilgrosso Francesco Chicchiriccò
            gwimmel Guido Wimmel
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: