Syncope
  1. Syncope
  2. SYNCOPE-292

NPE when accessing Configuration page with no global sync policy

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: console
    • Labels:
      None

      Description

      As reported in ML [1], there is an issue when no global sync policy exists.

      [1] http://syncope-dev.1063484.n5.nabble.com/NPE-in-Console-tt5712327.html

        Activity

        Hide
        Francesco Chicchiriccò added a comment -

        Bulk close for 1.1.0

        Show
        Francesco Chicchiriccò added a comment - Bulk close for 1.1.0
        Hide
        Hudson added a comment -

        Integrated in Syncope-trunk #19 (See https://builds.apache.org/job/Syncope-trunk/19/)
        SYNCOPE-292 (Revision 1439466)

        Result = SUCCESS
        jbernhardt :
        Files :

        • /syncope/trunk/client/src/main/java/org/apache/syncope/client/services/proxy/ReportServiceProxy.java
        Show
        Hudson added a comment - Integrated in Syncope-trunk #19 (See https://builds.apache.org/job/Syncope-trunk/19/ ) SYNCOPE-292 (Revision 1439466) Result = SUCCESS jbernhardt : Files : /syncope/trunk/client/src/main/java/org/apache/syncope/client/services/proxy/ReportServiceProxy.java
        Hide
        Colm O hEigeartaigh added a comment -

        Thanks, fix confirmed.

        Colm.

        Show
        Colm O hEigeartaigh added a comment - Thanks, fix confirmed. Colm.
        Hide
        Jan Bernhardt added a comment -

        I agree with you Colm. If no global policy is available, it should not be listed as ("0") policy in console.

        I'll fix this as well.

        Show
        Jan Bernhardt added a comment - I agree with you Colm. If no global policy is available, it should not be listed as ("0") policy in console. I'll fix this as well.
        Hide
        Colm O hEigeartaigh added a comment - - edited

        Thanks Jan! Fix confirmed.

        However, I am seeing something else which is slightly odd. If I browse to the Configuration page, and to "Synchronization Policies", I see:

        0 Synchronization Policy

        Same goes for Account Policies + Password Policies. Instead of listing a policy with id of "0" for each case, it should just not list any policy right?

        Colm.

        Ps. An error appears in the logs:

        SEVERE: Servlet.service() for servlet [syncope-core-rest] in context with path [/syncope] threw exception [Request processing failed; nested exception is org.apache.syncope.core.persistence.dao.NotFoundException: No account policy found] with root cause
        org.apache.syncope.core.persistence.dao.NotFoundException: No account policy found
        at org.apache.syncope.core.rest.controller.PolicyController.getGlobalAccountPolicy(PolicyController.java:205)

        Show
        Colm O hEigeartaigh added a comment - - edited Thanks Jan! Fix confirmed. However, I am seeing something else which is slightly odd. If I browse to the Configuration page, and to "Synchronization Policies", I see: 0 Synchronization Policy Same goes for Account Policies + Password Policies. Instead of listing a policy with id of "0" for each case, it should just not list any policy right? Colm. Ps. An error appears in the logs: SEVERE: Servlet.service() for servlet [syncope-core-rest] in context with path [/syncope] threw exception [Request processing failed; nested exception is org.apache.syncope.core.persistence.dao.NotFoundException: No account policy found] with root cause org.apache.syncope.core.persistence.dao.NotFoundException: No account policy found at org.apache.syncope.core.rest.controller.PolicyController.getGlobalAccountPolicy(PolicyController.java:205)
        Hide
        Hudson added a comment -

        Integrated in Syncope-trunk #17 (See https://builds.apache.org/job/Syncope-trunk/17/)
        SYNCOPE-292 (Revision 1439361)

        Result = SUCCESS
        jbernhardt :
        Files :

        • /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/PolicyRestClient.java
        Show
        Hudson added a comment - Integrated in Syncope-trunk #17 (See https://builds.apache.org/job/Syncope-trunk/17/ ) SYNCOPE-292 (Revision 1439361) Result = SUCCESS jbernhardt : Files : /syncope/trunk/console/src/main/java/org/apache/syncope/console/rest/PolicyRestClient.java
        Hide
        Jan Bernhardt added a comment -

        I'll check if new Service proxies are responsible for that.

        Show
        Jan Bernhardt added a comment - I'll check if new Service proxies are responsible for that.

          People

          • Assignee:
            Jan Bernhardt
            Reporter:
            Francesco Chicchiriccò
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development