Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
1.1.0
-
None
-
None
Description
Inside the NotificationTest there are several try catch blocks like below:
} catch (Exception e) {
LOG.error("Unexpected exception", e);
fail("Unexpected exception while setting SMTP host and port");
}
This makes the code harder to read and at least on the junit level it swallows the exception details and stack trace.
I propose to remove these blocks and instead let each of these method just throw Exception. junit will then report the exception nicely.