[SVN-925] new dumper bug can wipe files

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Invalid
• Affects Version/s: all
• Fix Version/s: unscheduled
• Component/s: libsvn_repos

Environment

other

• Assignee: Unassigned
• Reporter: Ben Collins-Sussman
• Created: 10/Oct/02 05:24
• Updated: 05/Oct/05 16:48
• Resolved: 05/Oct/05 16:48

Description

Discovered this dumper bug tonight.  It's rather scary, as it bit me
(and some others).

The reproduction recipe is this:  

1.  make a commit that is nothing but a single propchange to a file.
2.  svnadmin dump repos > dumpfile

Now look at 'dumpfile'.  Notice that it actually says
"Text-content-length: 0" for the file node that was proppatched. 
That's totally wrong.  The node should *only* contain a
"Prop-content-length:" header, not both text and prop content length.
 The extra text-content-length header is (correctly) interpreted by
the dumper as:  "replace the text of the file with new text that is 0
bytes long."

I don't know why our dumper is inserting the extra header.  Cmpilato
is looking into it.

(The way we got around this bug, by the way, was to hand-edit our
dumpfile and remove the bogus "Text-content-length: 0" headers on the
proper nodes, then reload the dumpfile.  Apparently our working copies
never received the text-zeroing when updating, for who-knows-why
reason.  Maybe that's a separate bug right there.)