Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-600

Can't add a dir with props

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • all
    • 0.14.0
    • src
    • None

    Description

      Here's a repro recipe
      
      svn mkdir foo
      svn pset svn:ignore bar foo
      svn ci -m "Add a dir with props"
      
      Note the segfault because dir_baton in NULL.  Here is a backtrace from gdb:
      
      GNU gdb 5.1
      Copyright 2001 Free Software Foundation, Inc.
      GDB is free software, covered by the GNU General Public License, and you are
      welcome to change it and/or distribute copies of it under certain conditions.
      Type "show copying" to see the conditions.
      There is absolutely no warranty for GDB.  Type "show warranty" for details.
      This GDB was configured as "i386-linux"...
      (gdb) run ci -m "Add a dir with props"
      Starting program: /home/kevin/bin/svn ci -m "Add a dir with props"
      [New Thread 1024 (LWP 17308)]
      
      Program received signal SIGSEGV, Segmentation fault.
      [Switching to Thread 1024 (LWP 17308)]
      0x0808216b in change_dir_prop (dir_baton=0x0, name=0x80f38d0, value=0x80f3850)
          at subversion/libsvn_delta/compose_editors.c:401
      401	  err = (* (d->edit_baton->editor_1->change_dir_prop))
      (gdb) bt
      #0  0x0808216b in change_dir_prop (dir_baton=0x0, name=0x80f38d0, 
          value=0x80f3850) at subversion/libsvn_delta/compose_editors.c:401
      #1  0x080604c3 in do_prop_deltas (path=0x80f2cf8, entry=0x80f4bc0, 
          editor=0x80e5ff8, baton=0x0, pool=0x80f2ad0)
          at subversion/libsvn_wc/adm_crawler.c:624
      #2  0x08060dfa in report_single_mod (name=0x80f0b78 "blah", entry=0x80f4bc0, 
          stack=0xbffff960, affected_targets=0x80e6030, locks=0x80e6090, 
          editor=0x80e5ff8, edit_baton=0x80e5fe0, revnum_fn=0x80c5b50, 
          rev_baton=0x80e5b18, youngest_rev=0xbffff95c, dir_baton=0xbffff8d8, 
          adds_only=0, copy_mode=0, top_pool=0x80d7638)
          at subversion/libsvn_wc/adm_crawler.c:1161
      #3  0x08061604 in crawl_dir (path=0x80d8a70, dir_baton=0x80e65d8, 
          editor=0x80e5ff8, edit_baton=0x80e5fe0, revnum_fn=0x80c5b50, 
          rev_baton=0x80e5b18, youngest_rev=0xbffff95c, adds_only=0, copy_mode=0, 
          stack=0xbffff960, affected_targets=0x80e6030, locks=0x80e6090, 
          top_pool=0x80d7638) at subversion/libsvn_wc/adm_crawler.c:1469
      #4  0x08061713 in crawl_local_mods (parent_dir=0x80d8a70, 
          condensed_targets=0x80d8a80, editor=0x80e5ff8, edit_baton=0x80e5fe0, 
          revnum_fn=0x80c5b50, rev_baton=0x80e5b18, locked_dirs=0x80e6090, 
          affected_targets=0x80e6030, pool=0x80d7638)
          at subversion/libsvn_wc/adm_crawler.c:1550
      #5  0x08062712 in svn_wc_crawl_local_mods (parent_dir=0x80d8a70, 
          condensed_targets=0x80d8a80, editor=0x80e5ff8, edit_baton=0x80e5fe0, 
          revnum_fn=0x80c5b50, rev_baton=0x80e5b18, pool=0x80d7638)
          at subversion/libsvn_wc/adm_crawler.c:2208
      #6  0x08052aa7 in send_to_repos (committed_rev=0xbffffb10, 
          committed_date=0xbffffb0c, committed_author=0xbffffb08, before_editor=0x0, 
          before_edit_baton=0x0, after_editor=0x80d8980, after_edit_baton=0x80d8978, 
          base_dir=0x80d8a70, condensed_targets=0x80d8a80, url=0x80e5078, 
          new_entry=0x0, auth_baton=0x80d7858, log_msg=0x80d7818, xml_dst=0x0, 
          revision=-1, pool=0x80d7638) at subversion/libsvn_client/commit.c:606
      #7  0x08052d59 in svn_client_commit (committed_rev=0xbffffb10, 
          committed_date=0xbffffb0c, committed_author=0xbffffb08, before_editor=0x0, 
          before_edit_baton=0x0, after_editor=0x80d8980, after_edit_baton=0x80d8978, 
          auth_baton=0x80d7858, targets=0x80d7828, log_msg=0x80d7818, xml_dst=0x0, 
          revision=-1, pool=0x80d7638) at subversion/libsvn_client/commit.c:744
      #8  0x0804b0eb in svn_cl__commit (os=0x80d77b8, opt_state=0xbffffb70, 
          pool=0x80d7638) at subversion/clients/cmdline/commit-cmd.c:110
      #9  0x0804dbaf in main (argc=4, argv=0xbffffc54)
          at subversion/clients/cmdline/main.c:610
      #10 0x4020865f in __libc_start_main () from /lib/libc.so.6
      (gdb) quit
      The program is running.  Exit anyway? (y or n)
      

      Original issue reported by kevin

      Attachments

        Activity

          People

            Unassigned Unassigned
            subversion-importer Subversion Importer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: