[SVN-4722] checksum fail during commit when delta is 16K

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.6, 1.9.7
• Fix Version/s: 1.9.9
• Component/s: libsvn_fs_fs
• Assignee: Unassigned
• Reporter: Philip Martin
• Created: 08/Mar/18 11:35
• Updated: 24/Jul/18 20:20
• Resolved: 13/Jul/18 10:27

Description

As discussed

Email to dev@, from Philip Martin, 2018-03-03, "Re: SHA-1 collision in repository?", archived at mail-archives.apache.org, svn.haxx.se

There is an error in the checksum code added to 1.9.7 1.9.6 to detect SHA1 collisions. The expanded length is calculated incorrectly and when the delta length is a multiple of 16K the checksum calculation stops early and fails.

Symptom: Commits fail with a false "Filesystem is corrupt" error.