[SVN-4622] revert as root always notifies for files

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: all
• Component/s: libsvn_subr
• Assignee: Unassigned
• Reporter: Philip Martin
• Created: 15/Feb/16 11:17
• Updated: 26/Dec/23 17:59

Description

$ svnadmin create repo
$ svn import -mm repo/format file://`pwd`/repo/f
$ umask 0022
$ svn co file://`pwd`/repo wc
$ sudo svn revert wc/f
Reverted 'wc/f'

The function svn_io__is_finfo_read_only() will check the world permissions when invoked with uid=root. A typical umask removes world write so this means that root sees every file as read-only. This causes the revert code to invoke svn_io_set_file_read_write() and notify. However svn_io_set_file_read_write() sets the owner permissions, an operation that succeeds when run as root, and obeys the umask so the world permissions remain read-only.

Reported by:
https://mail-archives.apache.org/mod_mbox/subversion-users/201602.mbox/%3C56C0738E.9010508%40i.ua%3E
http://svn.haxx.se/users/archive-2016-02/0061.shtml