Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-4622

revert as root always notifies for files

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: all
    • Fix Version/s: None
    • Component/s: libsvn_subr
    • Labels:
      None

      Description

      $ svnadmin create repo
      $ svn import -mm repo/format file://`pwd`/repo/f
      $ umask 0022
      $ svn co file://`pwd`/repo wc
      $ sudo svn revert wc/f
      Reverted 'wc/f'

      The function svn_io__is_finfo_read_only() will check the world permissions when invoked with uid=root. A typical umask removes world write so this means that root sees every file as read-only. This causes the revert code to invoke svn_io_set_file_read_write() and notify. However svn_io_set_file_read_write() sets the owner permissions, an operation that succeeds when run as root, and obeys the umask so the world permissions remain read-only.

      Reported by:
      https://mail-archives.apache.org/mod_mbox/subversion-users/201602.mbox/%3C56C0738E.9010508%40i.ua%3E
      http://svn.haxx.se/users/archive-2016-02/0061.shtml

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              philipm Philip Martin
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: