Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-4503

Revert SVN__STREAM_CHUNK_SIZE back to 16kb (r1586922)

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: ---
    • Fix Version/s: 1.9.0
    • Component/s: libsvn_subr
    • Labels:
      None

      Description

      There is no need to change global and widely used constant for specific FSFS
      optimization. Despite it marked as private, it's declared in public header and
      it is better to keep it unchanged to prevent possible compatibility problems.
      
      We have had problems with big read buffers used in config read code due to
      inefficient handling of large allocation by apr_allocator_t [1]. This particular
      problem was fixed in r1581296, but there is no reason to reintroduce this class
      of issues back again.
      
      [1]
      http://mail-archives.apache.org/mod_mbox/apr-dev/201405.mbox/%3CCA+t0gk2VZ-5y5uF3WnaF7Axmt3HBG87mCZJLS3yNscee5JT5PA@mail.gmail.com%3E
      
      Related discussions:
      http://svn.haxx.se/dev/archive-2014-04/0169.shtml
      http://svn.haxx.se/dev/archive-2004-11/0123.shtml
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ivan Ivan Zhakov
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: