[SVN-4466] confusing error when socket is closed with mod_deflate enabled

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: trunk
• Fix Version/s: ---
• Component/s: libsvn_ra_serf
• Assignee: Unassigned
• Reporter: Philip Martin
• Created: 27/Jan/14 19:15
• Updated: 28/Jan/14 09:47

Description

Configure Apache with "SetOutputFilter DEFLATE". Arrange for the Apache process
to die while sending a response, the client reports the error:

../src-1.8/subversion/svn/checkout-cmd.c:168,
../src-1.8/subversion/libsvn_client/checkout.c:197,
../src-1.8/subversion/libsvn_client/checkout.c:166,
../src-1.8/subversion/libsvn_client/update.c:614,
../src-1.8/subversion/libsvn_client/update.c:466,
../src-1.8/subversion/libsvn_wc/adm_crawler.c:845,
../src-1.8/subversion/libsvn_ra_serf/update.c:2899,
../src-1.8/subversion/libsvn_ra_serf/util.c:2183,
../src-1.8/subversion/libsvn_ra_serf/util.c:2164,
../src-1.8/subversion/libsvn_ra_serf/util.c:1726: (apr_err=120104)
svn: E120104: ra_serf: An error occurred during decompression

It's true that there was an error during decompression but the real error was
the socket read failing because the server closed the connection.

Trunk reports the same error:

../src/subversion/svn/checkout-cmd.c:168,
../src/subversion/libsvn_client/checkout.c:201,
../src/subversion/libsvn_client/checkout.c:170,
../src/subversion/libsvn_client/update.c:614,
../src/subversion/libsvn_client/update.c:466,
../src/subversion/libsvn_wc/adm_crawler.c:844,
../src/subversion/libsvn_ra_serf/update.c:2596,
../src/subversion/libsvn_ra_serf/update.c:2586,
../src/subversion/libsvn_ra_serf/update.c:2516,
../src/subversion/libsvn_ra_serf/util.c:872,
../src/subversion/libsvn_ra_serf/util.c:1399,
../src/subversion/libsvn_ra_serf/util.c:1380,
../src/subversion/libsvn_ra_serf/update.c:2327,
../src/subversion/libsvn_ra_serf/xml.c:1014: (apr_err=120104)
svn: E120104: ra_serf: An error occurred during decompression

The 1.7/neon client has a different error:

../src-1.7/subversion/svn/checkout-cmd.c:168: (apr_err=120108)
../src-1.7/subversion/libsvn_client/checkout.c:191: (apr_err=120108)
../src-1.7/subversion/libsvn_client/update.c:559: (apr_err=120108)
../src-1.7/subversion/libsvn_client/update.c:419: (apr_err=120108)
../src-1.7/subversion/libsvn_ra_serf/update.c:2416: (apr_err=120108)
../src-1.7/subversion/libsvn_ra_serf/update.c:2416: (apr_err=120108)
svn: E120108: Error retrieving REPORT (120108): APR does not understand this
error code

I'm using gdb to trigger the server error.  Set a breakpoint on
mod_dav_svn/reports/update.c:upd_add_file, do a checkout that sends lots of
files, after hitting the breakpoint a few times kill the Apache process.