Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-4440

Subversion sets permissions on files, when it shouldn't

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 1.8.x
    • ---
    • libsvn_subr
    • None

    Description

      As discussed in this thread:
      http://svn.haxx.se/users/archive-2013-10/0095.shtml, subversion sets file
      permissions on files at commit.
      The file doesn't have svn:eol-style, svn:keywords or svn:needs-lock properties
      set, and subversion doesn't rewrite it (it has the same inode before and after
      the commit).
      So according to these and judging from this mail:
      http://svn.haxx.se/users/archive-2013-10/0180.shtml, I consider this a bug,
      which not only prevents one from maintaining file permissions and ownership in
      subversion properties (subversion will set the file to umask permissions on
      every commit), but this behaviour is not expected from the user, and can pose
      ill effects.
      
      Please remove this by deleting the chmod from the commit codepath (from a simple
      grep, it seems to be called from subversion/libsvn_subr/io.c, so I choose that
      subcomponent).
      
      I set "found in version" to 1.8.x, but I'm sure it's in 1.7, and not sure about
      earlier versions.
      
      Thanks.
      

      Original issue reported by bra

      Attachments

        Activity

          People

            Unassigned Unassigned
            subversion-importer Subversion Importer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: