[SVN-4359] wrong notification during repository packing

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.x
• Fix Version/s: ---
• Component/s: libsvn_repos
• Assignee: Unassigned
• Reporter: Philip Martin
• Created: 23/Apr/13 12:36
• Updated: 27/Oct/18 16:30
• Resolved: 23/Apr/13 16:23

Description

The repos layer converts the FS packing actions to repos actions but gets it
wrong.  The result is that "svnadmin pack" doesn't display notifications in 1.7
or 1.8.  The testsuite fails due to unexpected notifications with this patch:

Index: ../src/subversion/libsvn_repos/fs-wrap.c
===================================================================
--- ../src/subversion/libsvn_repos/fs-wrap.c	(revision 1470841)
+++ ../src/subversion/libsvn_repos/fs-wrap.c	(working copy)
@@ -740,7 +740,10 @@ pack_notify_func(void *baton,
   struct pack_notify_baton *pnb = baton;
   svn_repos_notify_t *notify;
 
-  notify = svn_repos_notify_create(pack_action + 3, pool);
+  notify = svn_repos_notify_create(pack_action
+                                   + svn_repos_notify_pack_shard_start
+                                   - svn_fs_pack_notify_start,
+                                   pool);
   notify->shard = shard;
   pnb->notify_func(pnb->notify_baton, notify, pool);