Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-4359

wrong notification during repository packing

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.7.x
    • ---
    • libsvn_repos
    • None

    Description

      The repos layer converts the FS packing actions to repos actions but gets it
      wrong.  The result is that "svnadmin pack" doesn't display notifications in 1.7
      or 1.8.  The testsuite fails due to unexpected notifications with this patch:
      
      Index: ../src/subversion/libsvn_repos/fs-wrap.c
      ===================================================================
      --- ../src/subversion/libsvn_repos/fs-wrap.c	(revision 1470841)
      +++ ../src/subversion/libsvn_repos/fs-wrap.c	(working copy)
      @@ -740,7 +740,10 @@ pack_notify_func(void *baton,
         struct pack_notify_baton *pnb = baton;
         svn_repos_notify_t *notify;
       
      -  notify = svn_repos_notify_create(pack_action + 3, pool);
      +  notify = svn_repos_notify_create(pack_action
      +                                   + svn_repos_notify_pack_shard_start
      +                                   - svn_fs_pack_notify_start,
      +                                   pool);
         notify->shard = shard;
         pnb->notify_func(pnb->notify_baton, notify, pool);
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            philipm Philip Martin
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: