Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-4131

svnmucc uses Subversion-private APIs

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Cannot Reproduce
    • 1.6.x
    • ---
    • svnmucc
    • None

    Description

      svnmucc uses the Subversion-private API's, svn_cmdline__apply_config_options()
      and svn_cmdline__parse_config_option().  However, as a tools/ project it should
      use only public API's where possible:
      
      % cd tools
      % grep \#include **/*.c  | grep private
      client-side/svnmucc/svnmucc.c:#include "private/svn_cmdline_private.h"
      dev/svnraisetreeconflict/main.c:#include "private/svn_wc_private.h"
      dev/svnraisetreeconflict/main.c:#include "svn_private_config.h"
      server-side/svn-rep-sharing-stats.c:#include "svn_private_config.h"
      
      This could be fixed either by making svnmucc a core binary
      (subversion/svnmucc/svnmucc.c) or by promoting those API's to be public (which
      involves more work than just renaming things: a constructor for
      svn_cmdline__config_argument_t would need to be created, and perhaps the warning
      handling changed).
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            danielsh Daniel Shahaf
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: