Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-3846

interactive prompt should not interrupt updates

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.x
    • Fix Version/s: 1.8.0
    • Component/s: cmdline client
    • Labels:
      None

      Description

      When the command line client encounters a conflict during an update it immediately 
      prompts the user for feedback and interrupts the update until the user provides 
      some input. When updates take long periods of time this can be very annoying when 
      only very few conflicts exist. Ideally the client should detect the conflict and 
      proceed with the updates and only request user feedback at the end, so that the 
      user does not have to constantly pay attention to the client output while it 
      updates.
      

      Original issue reported by castano

        Activity

        Hide
        stsp Stefan Sperling added a comment -

        It doesn't look like there was a mailing list thread discussing this issue, as
        required by our bugtracker guidelines. Closing as INVALID.
        
        (Ignacio, it sounds like you want to use the --non-interactive and/or --accept
        options.)
        

        Show
        stsp Stefan Sperling added a comment - It doesn't look like there was a mailing list thread discussing this issue, as required by our bugtracker guidelines. Closing as INVALID. (Ignacio, it sounds like you want to use the --non-interactive and/or --accept options.)
        Hide
        subversion-importer Subversion Importer added a comment -

        I've skimmed the mailing list for this particular suggestion, and I don't think 
        it's been discussed, but there are hundreds of messages so I could have easily 
        missed it. This is actually so obvious, that I'd be surprised if I'm the first one 
        to suggest it, so I apologize if that was the case.
        
        --non-interactive or --accept do not accomplish what I suggest. I'm suggesting 
        that the interactive mode should not interrupt the update, but only request the 
        user's input when there's not more work left to be done.
        
        I know I could use non-interactive updates and resolve conflicts manually 
        afterwards, but that's more laborious. I'm simply suggesting a slight change in 
        the behavior of the interactive prompt that would improve users productivity and 
        as far as I can tell would not have any negative side effects, other than possibly 
        some increased code complexity.
        

        Original comment by castano

        Show
        subversion-importer Subversion Importer added a comment - I've skimmed the mailing list for this particular suggestion, and I don't think it's been discussed, but there are hundreds of messages so I could have easily missed it. This is actually so obvious, that I'd be surprised if I'm the first one to suggest it, so I apologize if that was the case. --non-interactive or --accept do not accomplish what I suggest. I'm suggesting that the interactive mode should not interrupt the update, but only request the user's input when there's not more work left to be done. I know I could use non-interactive updates and resolve conflicts manually afterwards, but that's more laborious. I'm simply suggesting a slight change in the behavior of the interactive prompt that would improve users productivity and as far as I can tell would not have any negative side effects, other than possibly some increased code complexity. Original comment by castano
        Hide
        stsp Stefan Sperling added a comment -

        OK, I understand what you mean.
        
        The idea is that if there is no mailing list thread, you start one :)
        We don't use the issue tracker for discussion because it isn't a good discussion
        forum, and not many people (apart from developers) do closely follow what's
        happening here. So please mail the users@ list with your suggestion to collect
        some feedback from the community first. Then we can reopen the issue. Thanks!
        

        Show
        stsp Stefan Sperling added a comment - OK, I understand what you mean. The idea is that if there is no mailing list thread, you start one :) We don't use the issue tracker for discussion because it isn't a good discussion forum, and not many people (apart from developers) do closely follow what's happening here. So please mail the users@ list with your suggestion to collect some feedback from the community first. Then we can reopen the issue. Thanks!
        Hide
        danielsh Daniel Shahaf (äñ§€¥£¢) added a comment -

        FWIW sounds like a reasonable request to me, +1.
        
        (particularly if the interactive prompt can cause the update to time out? is that the case?)
        

        Show
        danielsh Daniel Shahaf (äñ§€¥£¢) added a comment - FWIW sounds like a reasonable request to me, +1. (particularly if the interactive prompt can cause the update to time out? is that the case?)
        Hide
        stsp Stefan Sperling added a comment -

        Fair enough, then let's reopen it.
        

        Show
        stsp Stefan Sperling added a comment - Fair enough, then let's reopen it.
        Hide
        stsp Stefan Sperling added a comment -

        The current trunk code will always postpone conflicts until an
        update/switch/merge has fully completed, and then launch the interactive
        conflict resolver. Subversion 1.8 will likely be released with this behaviour,
        so I'm moving this into the 1.8.0 milestone.
        

        Show
        stsp Stefan Sperling added a comment - The current trunk code will always postpone conflicts until an update/switch/merge has fully completed, and then launch the interactive conflict resolver. Subversion 1.8 will likely be released with this behaviour, so I'm moving this into the 1.8.0 milestone.
        Hide
        danielsh Daniel Shahaf (äñ§€¥£¢) added a comment -

        #desc7 sounds as though the immediate problem (the TCP traffic blocking until
        the interactive prompt has been answered) is resolved.  Is there any further
        work to do here for 1.8?  If not, let's resolve this issue (and file new ones
        for possible further enhancements that need not block the release).
        

        Show
        danielsh Daniel Shahaf (äñ§€¥£¢) added a comment - #desc7 sounds as though the immediate problem (the TCP traffic blocking until the interactive prompt has been answered) is resolved. Is there any further work to do here for 1.8? If not, let's resolve this issue (and file new ones for possible further enhancements that need not block the release).
        Hide
        stsp Stefan Sperling added a comment -

        Yes, it's very likely that 1.8 will behave similarly to current trunk. There is
        still some fallout from the change (e.g. interactive conflict resolution for
        properties is broken according to Bert). But those problems can be tracked
        separately, so I'm closing this issue.
        

        Show
        stsp Stefan Sperling added a comment - Yes, it's very likely that 1.8 will behave similarly to current trunk. There is still some fallout from the change (e.g. interactive conflict resolution for properties is broken according to Bert). But those problems can be tracked separately, so I'm closing this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            subversion-importer Subversion Importer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development