[SVN-3733] API layering violation in repository loading logic

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.6.x
• Fix Version/s: 1.7.0
• Component/s: libsvn_repos
• Assignee: Unassigned
• Reporter: C. Michael Pilato
• Created: 19/Oct/10 14:22
• Updated: 27/Oct/18 16:36
• Resolved: 19/Oct/10 16:03

Description

While in course of making some other changes, I noticed an "oops" in
libsvn_repos/load.c.  This file contains two chunks of code:  (1) a dumpstream
parser which drives a caller-supplied vtable implementation and baton pair, and
(2) a specific vtable implementation and baton which can be used to load
dumpstream data into a Subversion repository.

The "oops" is that some use of the (2)'s specific baton has crept into (1),
which isn't allowed to know the details of the baton it is passing around.