Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-3619

translation stream does not expand keywords on partial reads

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Invalid
    • trunk
    • 1.7.0
    • libsvn_subr
    • None

    Description

      From #svn-dev:
      
      <stsp> svn_subst_stream_translated() does not expand keywords if they're not
      read in their entirety by the caller
      <stsp> is that a bug?
      <stsp> i would expect that, if I have the input containing a keyword such as
      One$MyKeyword$Two, which expands to "my keyword expanded", and I read up to the
      position of the character K, the result would be "Onemy"
      <stsp> but what is actually returned from svn_stream_read is One$My
      <stsp> that makes setting a mark within a keyword rather pointless
      <julianf> stsp: ew, that's an ugly bug in stream_translated.
      <julianf> That's just waiting to blow up.
      <stsp> julianf, yeah I think it should read ahead, expand the keyword, and
      return part of the expansion
      <julianf> +1
      
      See also r936844 which is related.
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              stsp Stefan Sperling
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: