[SVN-3542] pre-revprop-change hook executed twice by mod_dav_svn

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.6.x
• Fix Version/s: ---
• Component/s: mod_dav_svn
• Assignee: Unassigned
• Reporter: Subversion Importer
• Created: 03/Dec/09 15:41
• Updated: 27/Oct/18 16:35
• Resolved: 22/Jan/10 15:39

Description

If the pre-revprop-change hook script blocks the change, then mod_dav_svn tries
to set the property back to it's original value, and it calls the hook script
again for this (with the old property value).

Expected behaviour:  If the pre-revprop-change script blocks the change, then
mod_dav_svn shouldn't even try to revert it as the revert is a no-op.  (For DAV
transactions with multiple prop changes, if one of them fails then it shouldn't
be asking the pre-revprop-change hook scripts for permission to do the reverts,
it should just do the revert anyway and call the post-revprop-change script).

Causes:

- subversion/mod_dav_svn/deadprops.c:db_apply_rollback() passes TRUE as the
use_pre_revprop_change_hook parameter to svn_repos_fs_change_rev_prop3().  It
should be FALSE in the revert case.

- httpd/modules/dav/main/props.c:dav_prop_exec() doesn't remove the rollback
item if the property change fails.  Therefore we "revert" changes that never
happened.

Confirmation:
http://mail-archives.apache.org/mod_mbox/subversion-dev/200912.mbox/raw/[e-mail]%3E

I was asked to file this bug by C. Michael Pilato.

Original issue reported by jonfoster

Issue Links

• duplicates: SVN-3085 mod-dav-svn runs pre-revprop-change hook twice if it fails