[SVN-3169] svn_wc_set_changelist should release it's own error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.x
• Fix Version/s: 1.5.0
• Component/s: libsvn_wc
• Assignee: Unassigned
• Reporter: Bert Huijben
• Created: 10/Apr/08 13:48
• Updated: 27/Oct/18 16:36
• Resolved: 10/Mar/09 15:22

Description

svn_wc_set_changelist calls its notify func and assumes this notify func knows 
it must release the error provided to it.

----- adm_ops.c ------
if (entry->changelist && changelist && notify_func)
    {
      svn_error_t *unversioned_err =
        svn_error_createf(SVN_ERR_WC_CHANGELIST_MOVE, NULL,
                          _("Removing '%s' from changelist '%s'."),
                          path, entry->changelist);
      notify = svn_wc_create_notify(path, svn_wc_notify_changelist_moved, 
                                    pool);
      notify->err = unversioned_err;
      notify_func(notify_baton, notify, pool);
    }
--------------

subversion/svn/notify.c does this for this specific case, but the notify 
handler is part of the public api which does not define this requirement

----- subversion/svn/notify.c -----
case svn_wc_notify_changelist_failed:
      svn_handle_warning(stderr, n->err);
      svn_error_clear(n->err);
      break;

case svn_wc_notify_changelist_moved:
      svn_handle_warning(stderr, n->err);
      svn_error_clear(n->err);
      break;

----- subversion/svn/notify.c -----

The release of the err variable must be moved to the caller. As we can't change 
all receivers.

BTW. svn_wc_notify_changelist_failed can be removed if we do this before 1.5, 
as this value is never send to the notify listeners