Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-3168

svn_client_commit* sends invalid paths to svn_wc_notify_func2_t

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.x
    • Fix Version/s: 1.5.0
    • Component/s: libsvn_client
    • Labels:
      None

      Description

      The definition of svn_wc_notify_func2_t function uses svn_wc_notify_t which 
      declares
      
      typedef struct svn_wc_notify_t {
        /** Path, either absolute or relative to the current working directory
         * (i.e., not relative to an anchor). */
        const char *path;
      
      But calling (at the client level in pseudo code)
        svn.Commit("E:\tmp\wc",....)
      
      when your current directory is "E:\dev\sharpsvn\src\SharpSvn.Tests"
      
      Gives you notifies where the path is "tmp\wc\testfile.txt" which is neither a 
      valid relative path nor a valid absolute path.
      
      lgo mentioned on irc this bug is related to issue #1711.
      
      Further testing in the SharpSvn testsuite showed the issue is triggered on all 
      notifies from Commit() but is /not/ triggered from most import calls (did not 
      test all variants), or any of the other commands run from the SharpSvn 
      testsuite (extended version of AnkhSVN's NSvn tests).
      
      I really would like to have this issue fixed for (at least) absolute paths in 
      1.5, as this breaks using the notify for updating the in memory cache in the 
      new AnkhSVN. (More on this in issue #3147)
      

        Attachments

        1. 1_commit_patch.diff
          1 kB
          Bert Huijben
        2. 2_commit_patch-v3.txt
          8 kB
          Bert Huijben
        3. 3_commit_log-v3.txt
          1 kB
          Bert Huijben

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              rhuijben Bert Huijben
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: