Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-2978

SVNAdmin::dump never invokes the close() method of OutputInterface

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Invalid
    • Affects Version/s: 1.4.x
    • Fix Version/s: nonblocking
    • Component/s: bindings_javahl
    • Labels:
      None

      Description

      The OutputInterface object supplied to the SVNAdmin::dump function never gets
      its 'close()' method called. Looking at the SVNAdmin.cpp and Outputer.cpp code
      (trunk) it seems that this method *should* be called; but as of 1.4.5 it isn't.
      Not familiar enuf with native JNI jargon to really decipher if the Outputer's
      close method lookup of the OutputInterface's close is working...
      
      The lack of the close callback is problematic if your OutputInterface is an
      adapter for any kind of buffered output; the final 'close' is needed to ensure
      the underlying output stream is flushed and closed properly. Otherwise a
      truncated dump is the result. A workaround for 1.4.5 is to explicitly close this
      output stream yourself.
      

      Original issue reported by scato

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              subversion-importer Subversion Importer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: