Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
trunk
Description
If a file is in a changelist, and the user tries to add the file to another
changelist, it is removed from the first and added to the second without any
special comment:
$ svn cl foo plaza.jpg
Path 'plaza.jpg' is now a member of changelist 'foo'.
$ svn cl bar plaza.jpg
Path 'plaza.jpg' is now a member of changelist 'bar'.
But this can be dangerous. Perhaps the user already modified plaza.jpg as part
of changes made for changelist "foo", then later (forgetting that the file is in
"foo") added it to "bar" and made further modifications. Then (1) if the "foo"
changelist is committed, then the file's "foo" modifications would not be
included; (2) if the "bar" changelist is committed, then possibly-undesired
"foo" changes would accidentally be included in the "bar" commit.
On IRC, epg pointed out that with p4 people move files from one changelist to
another all the time, and that therefore a warning message would be too severe.
So epg suggested the following informational message: "moving 'plaza.jpg' from
changelist 'foo' to 'bar'.". That seems reasonable to me.
Original issue reported by mhagger