Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-2810

fix test failures caused by init behavior change in r22788; improve init logic

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: 1.5.0
    • Component/s: contrib/svnmerge.py
    • Labels:
      None

      Description

      This patch fixes bugs caused by r23052 and r22788 which caused tests to fail. 
      r23052 added "--force" to some commands and didn't add it to the tests that
      check for commands.  The changes to address r22788, a good idea that was just
      incomplete, are more interesting.  r22788 was intended to improve "svnmerge
      init" default values for the revision range.  The patch changes how it
      calculates those default values, and related tests.  
      
      This seems likely to be committed.  Dustin Mitchell said "I'm happy to commit
      this patch as it stands, and since Luke is working on patches that are probably
      of higher value, I'll write some additional tests for the new behavior and
      submit them to teh list for review.  I won't commit Luke's patch immediately, so
      please speak up if you have objections."
      
      Related discussion: http://www.orcaware.com/pipermail/svnmerge/2007-July/000953.html
      

      Original issue reported by lacall

        Attachments

        1. 9_furtherInitLogicFixesAsBegunByr22788-take3-unifiedFormat.patch
          11 kB
          Subversion Importer
        2. 8_renameParametersToActionInit.patch
          3 kB
          Subversion Importer
        3. 7_addNullreturnsToPulldomUsage.patch
          3 kB
          Subversion Importer
        4. 6_furtherInitLogicFixesAsBegunByr22788.patch
          11 kB
          Subversion Importer
        5. 5_addErrCheckingToPulldomUsage.patch
          4 kB
          Subversion Importer
        6. 4_usePulldomNotXml.patch
          3 kB
          Subversion Importer
        7. 3_svnmerge-automateTrunkToBranchInitScenario.patch
          8 kB
          Subversion Importer
        8. 2_fix-r22788.patch
          5 kB
          Subversion Importer
        9. 11_furtherInitLogicFixesAsBegunByr22788-take4-contextFormat.patch
          13 kB
          Subversion Importer
        10. 10_furtherInitLogicFixesAsBegunByr22788-take3-contextFormat.patch
          12 kB
          Subversion Importer
        11. 1_revise-2nd-r22788-and-tests.patch
          12 kB
          Subversion Importer

          Activity

            People

            • Assignee:
              blair Blair Zajac
              Reporter:
              subversion-importer Subversion Importer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: