Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-2303

Usage of the word "lock" in error messages and help is misleading

    Details

    • Type: Task
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: trunk
    • Fix Version/s: nonblocking
    • Component/s: unknown
    • Labels:

      Description

      There are several error messages concerning the working copy that use the term
      'locked' but have nothing to do with locking files.
      
      Examples from the po file:
      "Working copy not locked; this is probably a bug, please report"
      "Working copy locked, please run cleanup"
      "Error opening db lockfile"
      "Can't get exclusive lock on file '%s'"
      "Can't unlock charset translation mutex"
      "Cannot write lock/entries hashfile '%s'"
      
      "Attempt to unlock with non-empty unwind stack" 
      Also the help text in subversion/clients/cmdline/main.c (displayed by "svn help 
      SUBCOMMAND") suffers from the same problem: e.g. "svn help cleanup" says 
      "removing locks".
      
      These cases of using "locked" are misleading for users.
      
      Partial solution: prefix error messages with the module that's throwing them.
      
      Examples, used the filename as a hint for the prefix:
      "BDB: Error opening db lockfile"
      "FileIO: Can't get exclusive lock on file"
      "UTF: Can't unlock charset translation mutex"
      "FSFS: Cannot write lock/entries hashfile '%s'"
      "SVN Error: Working copy not locked; this is probably a bug, please report"
      "SVN Error: Attempt to unlock with non-empty unwind stack"
      
      this would get rid of  at least some of the ambiguities.
      

      Original issue reported by luebbe

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              subversion-importer Subversion Importer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: