Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-2207

ne_uri_parse() result not checked for failure enough

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: 1.5.0
    • Component/s: libsvn_ra_neon
    • Labels:
      None

      Description

      r12286 cleaned up one spot where the result of ne_uri_parse() was not being
      checked.  But Philip Martin points out that there are others:
      
         > I looked into fixing this; I didn't do it because there 
         > are other places where ne_uri_parse is used unchecked,
         > and some of those return through merge.c:end_element
         > and I wasn't sure how to handle the error.
      
      Ideally they should all be checked.
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kfogel Karl Fogel

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment