Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1706

Directory representations should be sorted to be diff'able

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Critical
    • Resolution: Invalid
    • all
    • unscheduled
    • libsvn_fs_base
    • None

    Description

      Directories are duplicated as fulltext many times in the repository.  They
      usually remain fulltext during deltification, because the order of entries
      changes a lot between revisions, making the svndiff even larger.
      
      The reason should be that libsvn_fs/dag.c/set_entry() uses a hash table during
      reading and writing the directory "skels", so the order is not preserved.
      
      In this particular case I think it is better not to use a hash table --- since
      only one entry is changed, an unsorted linear array works good enough.  Of
      course, code like svn_fs__parse_entries_skel() would then have to be duplicated.
      
      Another way is to sort the entries during deltification.
      
      I currently use 0.35.1, but since nothing about the problem is mentioned on the
      0.36 release notes, I'll assume this problem has been unchanged.
      

      Original issue reported by r6144

      Attachments

        Activity

          People

            Unassigned Unassigned
            subversion-importer Subversion Importer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: