Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1647

unnecessary NULL guarantees in some string/uri APIs

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: all
    • Fix Version/s: 1.0-consider
    • Component/s: libsvn_subr
    • Labels:
      None

      Description

      This is item #7 from Greg Hudson's list of API issues to solve for 1.0, in thread
      
      http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=139821
      
      It says:
      
        #7: Overly defensive programming in:
              svn_path_uri_endode
              svn_path_uri_decode
              svn_cstring_split_append
            The path_uri functions actually document that they will pass
            through NULL, even though there is no use case which makes that
            especially convenient.  svn_cstring_split_append accepts a NULL
            input even though it is not documented that it does so.
        IMPACT OF PROBLEM: Minor; we will be trapped into providing
            interface guarantees for these functions which we don't provide
            most places.
        DIFFICULTY OF FIX: Trivial.
      
      Ordinarily we wouldn't need an issue for something so trivial.  But since it's
      an API tweak that probably shouldn't happen in trunk unless it also happens in
      the 1.0 line, an issue will give us something concrete to refer to in
      discussions/voting.
      

        Attachments

        1. 2_1647-patch.txt
          5 kB
          Karl Fogel
        2. 1_1647-patch.txt
          4 kB
          Karl Fogel

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kfogel Karl Fogel
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: