Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1575

revamp logic for 'svn diff binaryfile'

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: all
    • Fix Version/s: unscheduled
    • Component/s: libsvn_client
    • Labels:

      Description

      At the moment, this command runs forever before noticing that the
      svn:mime-type is binary, and prints "cannot display, file marked as
      binary type."  I mean, it's still useful information that the binary
      files differ... but we can be smarter and faster:
      
      Instead, use the svn_wc_text_changed_p tricks: look at timestamps and
      filesizes for a possible quick answer.  If timestamps are identical,
      there's no diff.  If filesizes are different, there's definitely a
      diff, but look at the mimetype before trying to compute the diff;
      there's no point in computing the diff if you can't even display it.
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                sussman Ben Collins-Sussman
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: