Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1159

updates of already up-to-date working copies still rewrite all entries files

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • all
    • 0.26
    • libsvn_repos
    • None

    Description

      It I run 'svn up' on a working copy that is up to date all the entries
      files get rewritten. This is because the update editor gets sent entry
      properties for the directories. Here's the stack for an ra_local
      update (it happens for other RA layers as well)
      
      #0  change_dir_prop (dir_baton=0x8085f08, 
          name=0x400675bc "svn:entry:committed-date", value=0x80bf520, 
          pool=0x80bb208) at ../svn/subversion/libsvn_wc/update_editor.c:819
      #1  0x4005feb9 in change_dir_prop (c=0x8085f08, object=0x8085f08, 
          name=0x8085f08 "0_\b\b", value=0x8085f08, pool=0x8085f08)
          at ../svn/subversion/libsvn_repos/delta.c:414
      #2  0x4006026a in delta_proplists (c=0xbffff5c0, source_path=0x8085f60
      "/", 
          target_path=0x8085ec8 "/", change_fn=0x4005fe90 <change_dir_prop>, 
          object=0x8085f08, pool=0x8085f08)
          at ../svn/subversion/libsvn_repos/delta.c:483
      #3  0x40060adc in delta_dirs (c=0xbffff5c0, dir_baton=0x8085f08, 
          source_path=0x8085f60 "/", target_path=0x8085ec8 "/", pool=0x805e618)
          at ../svn/subversion/libsvn_repos/delta.c:856
      #4  0x4005fc3f in svn_repos_dir_delta (src_root=0x80b3110, 
          src_parent_dir=0x8085ec8 "/", src_entry=0x0, tgt_root=0x80c8068, 
          tgt_path=0xbffff5c0 "Ð\005\t\bÐ^\b\b\0201\v\bh\200\f\b\001", 
          editor=0x80905d0, edit_baton=0x8090608, text_deltas=134766344, 
          recurse=134766344, entry_props=134766344, use_copy_history=134766344, 
          pool=0x805e618) at ../svn/subversion/libsvn_repos/delta.c:356
      #5  0x40065b1a in svn_repos_finish_report (report_baton=0x8085ca8)
          at ../svn/subversion/libsvn_repos/reporter.c:367
      
      A quick fix would be to recognise that the incoming properties match
      the existing ones and discard them, but that strikes me as a hack. I
      think the real solution is to stop the entry properties getting sent.
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            philipm Philip Martin
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: