Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1021

svn_wc_resolve() should remove conflict-* entry attributes

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • all
    • Beta
    • libsvn_wc
    • None

    Description

      Currently, running 'svn resolve' will cleanup the conflict tmpfiles,
      but leaves the conflict-* attributes still present in the entries
      file.  While this is technically okay, it means that every attempt to
      get the status of a resolved file must verify that those three
      tmpfiles are missing from disk.  This is a missed efficiency
      opportunity.  If the entry is fixed to no longer have conflict-*
      attributes, these extraneous checks won't happen every time the status
      of the entry is calculated.
      
      I thought this code was behaving as I desired, sussman disagreed.  As
      it turns out, the code *does exist* but is commented out.  See
      resolve_conflict_on_entry() in libsvn_wc/adm_ops.c.
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            cmpilato C. Michael Pilato
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: