[SUREFIRE-912] A NPE is thrown when some test case fails in the ConcurrentReporterManager

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.12.4
• Component/s: Junit 4.7+ (parallel) support
• Environment: Windows 7
• Flags: Patch
• Assignee: Kristian Rosenvold
• Reporter: Cristian Vazzolla
• Created: 21/Sep/12 07:45
• Updated: 05/Apr/15 14:54
• Resolved: 21/Sep/12 15:18

Description

When using JUnit categories for testing some of the tests that fail will result in a NULL pointer exception being thrown from the ConcurrentReporterManager class and this breaks the surefire plugin execution so the tests that follow this will not get executed anymore.

The root cause of the problem is that in the testFailed method the getOrCreateTestMethod method is called which on one of the flows returns null which is not treated in the testFailed method and gives a null pointer exception.

I've created a patch for this issue in which I've modified the testFailed and the testAssumptionFailure methods to treat nicely the case when null is returned from getOrCreateTestMethod.

I've also attached the log file with the exception.

I have not included any test because this issue happens randomly not on a particular test case.