[SUREFIRE-727] Classpath too long on windows with useManifestOnlyJar=false

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.8.1
• Fix Version/s: 2.9
• Component/s: Maven Surefire Plugin
• Flags: Patch
• Assignee: Kristian Rosenvold
• Reporter: kevin aloisi
• Created: 18/Apr/11 10:17
• Updated: 19/Nov/19 12:27
• Resolved: 19/Apr/11 14:26

Description

If the useMandifestOnlyJar=false, then then jnuit won't run on windows because the classpath is to long. The better way to fork a java process is to set the CLASSPATH env variable instead of passing it on the command line.

This patch fixes the issue.

Index: src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
===================================================================
— src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java (revision 1092789)
+++ src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java (working copy)
@@ -221,13 +221,13 @@
}
else

{ - cli.createArg().setValue( "-classpath" ); - - cli.createArg().setValue( StringUtils.join( classPath.iterator(), File.pathSeparator ) ); +// cli.createArg().setValue( "-classpath" ); +// cli.createArg().setValue( StringUtils.join( classPath.iterator(), File.pathSeparator ) ); + cli.addEnvironment("CLASSPATH",StringUtils.join( classPath.iterator(), File.pathSeparator )); + + final String forkedBooter = ForkedBooter.class.getName(); - final String forkedBooter = ForkedBooter.class.getName(); - - cli.createArg().setValue( shadefire ? new Relocator( ).relocate( forkedBooter ) : forkedBooter); + cli.createArg().setValue( shadefire ? new Relocator( ).relocate( forkedBooter ) : forkedBooter); }

cli.setWorkingDirectory( workingDirectory.getAbsolutePath() );

Issue Links

• relates to: SUREFIRE-1723 Not using the manifest jar fails on Windows with 3.0.0-M4 and JDK 11