[SUREFIRE-2153] Replace SurefireReportGenerator with a new SurefireReportRenderer

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-M9
• Fix Version/s: 3.1.0
• Component/s: Maven Surefire Report Plugin
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 19/Feb/23 18:08
• Updated: 24/May/23 19:23
• Resolved: 04/May/23 07:24

Description

The problem with SurefireReportGenerator is that is has been written 10+ years ago. It does not use AbstractMavenReportRenderer which causes a lot of code duplication. It shall be superseded with SurefireReportRenderer which does extend from the abstract renderer.

The new renderer will also modernize the way data is displayed:

• SurefireReportParser is supposed to collect data, not to format it. This is a task of the view layer
• Separate percent and number formatters
• Hide full table row instead of leaving ugly condensed one because of hidden div
• Remove redudant div around verbatim block
• Simplify renderer due to the foundatation on abstact renderer
• Simplify tests

Issue Links

• causes: SUREFIRE-2166 Use ChoiceFormat to selectively render percentage and elapsed time in SurefireReportRenderer
• Is contained by: SUREFIRE-2130 Rewrite several test classes in report plugin for upcoming Doxia 2.0.0 stack
• relates to: MCHECKSTYLE-436 Replace CheckstyleReportGenerator with a new CheckstyleReportRenderer
• relates to: MPMD-375 Replace *ReportGenerators with new *ReportRenderers
• links to: GitHub Pull Request #625