[SUREFIRE-1445] Properties from configuration POM are not passed to Provider on JDK 9

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.19.1, 2.20, 2.20.1
• Fix Version/s: 2.21.0
• Component/s: Maven Failsafe Plugin, Maven Surefire Plugin
• Environment: JDK 9
• Assignee: Tibor Digana
• Reporter: Marc Philipp
• Created: 16/Nov/17 10:54
• Updated: 13/Jan/18 17:46
• Resolved: 02/Dec/17 15:27

Description

Given the POM below, the JUnitPlatformProvider can read "excludeTags" = "slow" from ProviderParameters.getProviderProperties() when it runs on JDK 8 but not on JDK 9.

The reason is that the constructor of SurefireProperties relies on an implementation detail of the class it extends, namely that putAll() will call put() for each entry. However, while Properties does that on JDK 8, it doesn't on JDK 9.

Here's a link to the line in SurefireProperties:
https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L62

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>junit5</groupId>
    <artifactId>tagging</artifactId>
    <version>1.0-SNAPSHOT</version>

    <build>
        <plugins>
            <plugin>
                <artifactId>maven-surefire-plugin</artifactId>
                <version>2.19.1</version>
                <configuration>
                    <properties>
                        <excludeTags>slow</excludeTags>
                    </properties>
                </configuration>
                <dependencies>
                    <dependency>
                        <groupId>org.junit.platform</groupId>
                        <artifactId>junit-platform-surefire-provider</artifactId>
                        <version>1.0.2</version>
                    </dependency>
                    <dependency>
                        <groupId>org.junit.jupiter</groupId>
                        <artifactId>junit-jupiter-engine</artifactId>
                        <version>5.0.2</version>
                    </dependency>
                </dependencies>
            </plugin>
        </plugins>
    </build>

    <dependencies>
        <dependency>
            <groupId>org.junit.jupiter</groupId>
            <artifactId>junit-jupiter-api</artifactId>
            <version>5.0.2</version>
            <scope>test</scope>
        </dependency>
    </dependencies>

</project>

Issue Links

• links to: GitHub Pull Request #171