Uploaded image for project: 'Maven Surefire'
  1. Maven Surefire
  2. SUREFIRE-1391

System Property variables processed twice in calculation of effective properties

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 2.20.1
    • Maven Surefire Plugin
    • None
    • Patch

    Description

      System property variables are processed twice in the calculation of effective properties. There is obviously no adverse impact on behavior, just unnecessary processing.

      static SurefireProperties calculateEffectiveProperties( Properties systemProperties,
                                                                  Map<String, String> systemPropertyVariables,
                                                                  Properties userProperties, SurefireProperties props )
          {
              SurefireProperties result = new SurefireProperties();
              result.copyPropertiesFrom( systemProperties );
      
              result.copyPropertiesFrom( props );
      
              copyProperties( result, systemPropertyVariables );
              copyProperties( result, systemPropertyVariables );
      
              // We used to take all of our system properties and dump them in with the
              // user specified properties for SUREFIRE-121, causing SUREFIRE-491.
              // Not gonna do THAT any more... instead, we only propagate those system properties
              // that have been explicitly specified by the user via -Dkey=value on the CLI
      
              result.copyPropertiesFrom( userProperties );
              return result;
          }
      

      Attachments

        Issue Links

          Activity

            People

              michael-o Michael Osipov
              andrew-j-cohen Andrew Cohen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 10m
                  10m
                  Remaining:
                  Remaining Estimate - 10m
                  10m
                  Logged:
                  Time Spent - Not Specified
                  Not Specified