Uploaded image for project: 'Maven Surefire'
  1. Maven Surefire
  2. SUREFIRE-1260

Add **/*Tests.java as one of the default include patterns

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 2.20
        • Component/s: None
        • Labels:
          None

          Description

          JUnit 5 tests use that suffix by convention. Adding the **/*Tests.java suffix to the default includes provides the correct out of the box behavior for those using the maven-surefire-plugin with the junit5-platform-surefire-provider.

          This issue is related to SUREFIRE-1206.

            Issue Links

            is duplicated by

            Improvement - An improvement or enhancement to an existing feature or task. SUREFIRE-1258 Make test classes inclusion pattern's default allow for plural

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              sbrannen Sam Brannen added a comment - - edited

              FYI: all Spring Framework projects also use *Tests as the naming convention for test classes.

              Show
              sbrannen Sam Brannen added a comment - - edited FYI: all Spring Framework projects also use *Tests as the naming convention for test classes.
              Hide
              Permalink
              tibor17 Tibor Digana added a comment -

              commit 2a4f413f9efd9a5d2ab53b1026c126c47856f71d

              Show
              tibor17 Tibor Digana added a comment - commit 2a4f413f9efd9a5d2ab53b1026c126c47856f71d
              Hide
              Permalink
              sbrannen Sam Brannen added a comment -

              Awesome!

              Thanks for making this change!

              Show
              sbrannen Sam Brannen added a comment - Awesome! Thanks for making this change!
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Jenkins build maven-surefire #1593 (See https://builds.apache.org/job/maven-surefire/1593/)
              SUREFIRE-1260 Add **/*Tests.java as one of the default include (tibor17: rev 2a4f413f9efd9a5d2ab53b1026c126c47856f71d)

              • (add) surefire-integration-tests/src/test/resources/surefire-1260-new-tests-pattern/src/test/java/pkg/JUnit4Tests.java
              • (edit) maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
              • (edit) maven-surefire-plugin/src/site/apt/examples/inclusion-exclusion.apt.vm
              • (add) surefire-integration-tests/src/test/resources/surefire-1260-new-tests-pattern/pom.xml
              • (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1260NewTestsPattern.java
              • (add) surefire-integration-tests/src/test/resources/surefire-1260-new-tests-pattern/src/test/java/pkg/JUnit3Tests.java
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-surefire #1593 (See https://builds.apache.org/job/maven-surefire/1593/ ) SUREFIRE-1260 Add **/*Tests.java as one of the default include (tibor17: rev 2a4f413f9efd9a5d2ab53b1026c126c47856f71d) (add) surefire-integration-tests/src/test/resources/surefire-1260-new-tests-pattern/src/test/java/pkg/JUnit4Tests.java (edit) maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java (edit) maven-surefire-plugin/src/site/apt/examples/inclusion-exclusion.apt.vm (add) surefire-integration-tests/src/test/resources/surefire-1260-new-tests-pattern/pom.xml (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1260NewTestsPattern.java (add) surefire-integration-tests/src/test/resources/surefire-1260-new-tests-pattern/src/test/java/pkg/JUnit3Tests.java

                People

                • Assignee:
                  tibor17 Tibor Digana
                  Reporter:
                  smoyer1 Steve Moyer
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development