[STRATOS-1565] Fix registry transactions exception handling

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.2
• Fix Version/s: 4.1.3
• Assignee: Unassigned
• Reporter: Akila Perera
• Created: 16/Sep/15 06:29
• Updated: 16/Sep/15 06:58
• Resolved: 16/Sep/15 06:31

Description

When performing Registry transactions, "beginTransaction" and "commitTransaction" methods should always be in a try block and RegistryException should be caught and rolled back by calling "rollbackTransaction" method. "rollbackTransaction" should also be in another try block and rollback exception should be properly logged.

For eg:

try

{ registryService.beginTransaction(); registryService.delete(resourcePath); registryService.commitTransaction(); }

catch (RegistryException e) {
try

{ registryService.rollbackTransaction(); }

catch (RegistryException e1) {
if (log.isErrorEnabled())

{ log.error("Could not rollback transaction", e1); }

}
String message = "Could not delete resource at " + resourcePath;
throw new AutoScalerException(message, e);
}

Buggy registry operations could result in unreleased locks.