Uploaded image for project: 'Struts 1'
  1. Struts 1
  2. STR-3160

TilesRequestProcessor processTilesDefinition returns false when a definition has been processed

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.0
    • 1.4.0
    • Tiles 2 Plugin
    • None
    • Patch

    Description

      Here is the code involved in TilesRequestProcessor.processTilesDefinition:

      if (container.isValidDefinition(definitionName, new Object[]

      { request, response }

      )) {
      retValue = response.isCommitted();
      try {
      container.render(definitionName, new Object[]

      { request, response }

      );
      } catch (TilesException e)

      { throw new ServletException("Cannot render definition '" + definitionName + "'"); }

      } else {
      // ignore not found
      if (log.isDebugEnabled())

      { log.debug("Cannot find definition '" + definitionName + "'"); }

      }

      the response.isCommitted() statement seems to return 'false' but the retValue should be set to 'true'
      as a definition was found at this point..

      Attachments

        1. TilesRequestProcessor.patch
          0.7 kB
          Yannick Haudry

        Activity

          People

            brenmcguire Antonio Petrelli
            yhaudry Yannick Haudry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: