[STR-2477] New DownloadAction adjusting buffer size - ASF JIRA

XML

Word

Printable

JSON

A review of the new DownloadAction code seems to have the following problem:

The getBufferSize method is defined:
protected int getBufferSize()

{ return DEFAULT_BUFFER_SIZE; }

But it does not appear to be used:

byte[] buffer = new byte[DEFAULT_BUFFER_SIZE];

A search of the code does indicate the getBufferSize method is actually called
anywhere, so overriding the method does not seem useful.

(Minor nits aside, the DownloadAction is very helpful – thanks!)