Uploaded image for project: 'Struts 1'
  1. Struts 1
  2. STR-2338

DispatchChainAction needs review

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • Future
    • None
    • Extras
    • None
    • Operating System: Mac OS X 10.0
      Platform: Macintosh
    • 33202

    Description

      As it is currently written, the DispatchChainAction is not much use because
      there is no way to specify in which catalog the command should be looked up.
      (It was written before the catalog model was applied to commons-chain.)
      Furthermore, members of the community have raised the real concern that it is
      risky to accept arbitrary URL parameters and use them to execute code without
      some way of enumerating which values are permitted.

      It should be pretty straightforward to make use of the new ActionConfig property
      map to specify any number of config values, including specifying a single
      literal catalog name or indicating a second parameter which can be used to find
      the catalog name, and also specifying enumerations of any valid values which
      might be submitted by request parameter.

      Also, note that there is an unreleased feature currently in the commons-chain
      CVS which allows you to use a single string to specify a catalog and a command
      (separated by a ":" character). The release of this code might provide an
      alternate way to bring this action class back into full usefulness.

      Since I don't plan to use the DispatchChainAction, this is a low priority for
      me, but I thought some of the issues should be documented, since I was going
      through them in a private email.

      Attachments

        Activity

          People

            germuska Joseph Lad Germuska
            germuska Joseph Lad Germuska
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: