[STR-2310] NPE in ModuleUtils.selectModule

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2.2, 1.2.4, 1.2.6 Beta, Nightly Build
• Fix Version/s: 1.2.7, 1.2 Family
• Component/s: Core
• Environment: Operating System: Windows XP; Platform: PC
• Bugzilla Id: 32661
• Assignee: Unassigned
• Reporter: Rich Feit
• Created: 13/Dec/04 09:37
• Updated: 21/Aug/07 08:43
• Resolved: 21/Aug/07 08:43

Description

If you pass in an unresolvable module prefix to ModuleUtils.selectModule(), you
get an NPE when the method tries to find message resources for the (null)
module. It looks like the method is meant to handle unresolvable modules,
though, since it initially does a null check after calling getModuleConfig().

Made this P3 because it's easy to work around. To reproduce this, just call
ModuleUtils.getInstance().selectModule( "/xyzzy", request, context ); where
"/xyzzy" is not a registered module.

Here's a patch (as if you need it ):

Index: src/share/org/apache/struts/util/ModuleUtils.java
===================================================================
— src/share/org/apache/struts/util/ModuleUtils.java (revision 111678)
+++ src/share/org/apache/struts/util/ModuleUtils.java (working copy)
@@ -241,20 +241,20 @@

if (config != null) {
request.setAttribute(Globals.MODULE_KEY, config);
+
+ MessageResourcesConfig[] mrConfig =
config.findMessageResourcesConfigs();
+ for(int i = 0; i < mrConfig.length; i++) {
+ String key = mrConfig[i].getKey();
+ MessageResources resources =
+ (MessageResources) context.getAttribute(key + prefix);
+ if (resources != null)

{ + request.setAttribute(key, resources); + }

else

{ + request.removeAttribute(key); + }

+ }
} else

{ request.removeAttribute(Globals.MODULE_KEY); }

-

• MessageResourcesConfig[] mrConfig = config.findMessageResourcesConfigs();
• for(int i = 0; i < mrConfig.length; i++) {
• String key = mrConfig[i].getKey();
• MessageResources resources =
• (MessageResources) context.getAttribute(key + prefix);
• if (resources != null) { - request.setAttribute(key, resources); - }

  else

  { - request.removeAttribute(key); - }
• }
  }
  }

Issue Links

• is duplicated by: STR-2738 NullPointerException in selectModule when tiles plugin set to moduleAware=true
• is duplicated by: STR-2433 Specify which module is causing an error in ModuleUtils.selectModule()